这是indexloc提供的服务，不要输入任何密码
Skip to content

allow setting check constraints on existing tables from console #3383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 27, 2019
Merged

allow setting check constraints on existing tables from console #3383

merged 13 commits into from
Nov 27, 2019

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Nov 20, 2019

Description

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

#1700

Solution and Design

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

Steps to test and verify

Limitations, known bugs & workarounds

@wawhal wawhal requested a review from rikinsk as a code owner November 20, 2019 08:51
@netlify
Copy link

netlify bot commented Nov 20, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 6609f21

https://deploy-preview-3383--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 20, 2019

Review app for commit e4bbc8e deployed to Heroku: https://hge-ci-pull-3383.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3383-e4bbc8e5

@rikinsk
Copy link
Member

rikinsk commented Nov 20, 2019

@wawhal Currently I need to define the check as CHECK (id > 0) for the constraint to be created. I should just need to enter id > 0

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 21, 2019

Review app for commit 2d9991c deployed to Heroku: https://hge-ci-pull-3383.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3383-2d9991cd

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 21, 2019

Review app for commit 3a02c9c deployed to Heroku: https://hge-ci-pull-3383.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3383-3a02c9cc

@rikinsk rikinsk added the c/console Related to console label Nov 21, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 26, 2019

Review app for commit 7eef4b5 deployed to Heroku: https://hge-ci-pull-3383.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3383-7eef4b55

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 26, 2019

Review app for commit 85a6ddc deployed to Heroku: https://hge-ci-pull-3383.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3383-85a6ddc2

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 26, 2019

Review app for commit 266286c deployed to Heroku: https://hge-ci-pull-3383.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3383-266286c5

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 27, 2019

Review app for commit 6609f21 deployed to Heroku: https://hge-ci-pull-3383.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3383-6609f219

@rikinsk rikinsk merged commit 0019808 into hasura:master Nov 27, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 27, 2019

Review app https://hge-ci-pull-3383.herokuapp.com is deleted

vacom pushed a commit to vacom/graphql-engine that referenced this pull request Nov 27, 2019
Merge pull request #1 from hasura/master
1c9ad8a 
allow setting check constraints on existing tables from console (hasura#3383)
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@polRk
allow setting check constraints on existing tables from console (hasu…
eaa7d74 
…ra#3383)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

Assignees

No one assigned

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wawhal @hasura-bot @rikinsk