这是indexloc提供的服务，不要输入任何密码
Skip to content

Issue 3312 dev.sh support python 3.7 #3356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 15, 2019
Merged

Issue 3312 dev.sh support python 3.7 #3356

merged 8 commits into from
Nov 15, 2019

Conversation

@jberryman
Copy link
Collaborator

@jberryman jberryman commented Nov 14, 2019

Affected components

  • Docs
  • Build System
  • Tests

Steps to test and verify

  • Run scripts/dev.sh test, etc.
  • Review corrected test in eed7098 (no one to git blame for review here)

@netlify
Copy link

netlify bot commented Nov 14, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 84cfe18

https://deploy-preview-3356--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 14, 2019

Review app for commit ecc8b3f deployed to Heroku: https://hge-ci-pull-3356.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3356-ecc8b3f1

@jberryman
Copy link
Collaborator Author

jberryman commented Nov 14, 2019

Hm, upgrade_test failed after "start the current build". Not sure what that's about. Don't have permissions to force rerunning. I'll try force pushing to trigger another.

@jberryman jberryman force-pushed the issue-3312-dev.sh-support-python-3.7 branch from ecc8b3f to 296eb28 Compare November 14, 2019 21:56
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 14, 2019

Review app for commit 296eb28 deployed to Heroku: https://hge-ci-pull-3356.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3356-296eb285

@jberryman
In tests/dev.sh: upgrade ruamel to support python 3.7. Closes hasura#…
da78a77 
…3312

Tested on python 3.5 and 3.7

We make light use of pyenv to set an appropriate python version if
installed. We could easily install a correct version too if we wanted
but that seemed invasive.

The newer ruamel was an annoying upgrade but also offers some
improvements that exposed some test suite issues (fixed later).
@jberryman
In tests: fix extraneous extra keys in yaml
92b1f9c
@jberryman
Fix product_mul_price test
a1da8bc 
The intention was to make this two cases, using a top-level YAML list.
The result was one test with duplicate keys (effectively only running
the second test). This is an error that's now flagged by newer ruamel.

Both tests needed to be "corrected" to pass and need review.
@jberryman
Add 'venv' to top gitignore, as standard name convention lsfor python…
9e0e424 
… venv's in this project
@jberryman
In dev.sh tests: use postgres:11.5-alpine-postgis image which boots 3…
5827d65 
… sec faster
@jberryman
dev.sh script: build before waiting for PG
256be84
@jberryman
dev.sh: support running only integration tests or haskell/unit tests …
505ea4d 
…individually
@jberryman
dev.sh: combine tix from unit/haskell tests and integration tests in …
84cfe18 
…final report
@jberryman jberryman force-pushed the issue-3312-dev.sh-support-python-3.7 branch from 296eb28 to 84cfe18 Compare November 14, 2019 23:53
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 15, 2019

Review app for commit 84cfe18 deployed to Heroku: https://hge-ci-pull-3356.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3356-84cfe18b

lexi-lambda
lexi-lambda approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@lexi-lambda lexi-lambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 15, 2019

Review app for commit 9bc9d3f deployed to Heroku: https://hge-ci-pull-3356.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3356-9bc9d3fa

@jberryman
Copy link
Collaborator Author

jberryman commented Nov 15, 2019

In test_console:

ERRO auto-update failed, run 'hasura update-cli' to update manually error="cannot update from a non-semver version: pull3356-9bc9d3fa"

@lexi-lambda
Copy link
Contributor

lexi-lambda commented Nov 15, 2019

Yeah, I saw that, which seems strange. I’m going to kick off the test_console job again once the rest of the workflow finishes (since CircleCI doesn’t seem to allow rerunning failed jobs until everything else finishes) to see if it was just something weird and transient.

@lexi-lambda lexi-lambda force-pushed the issue-3312-dev.sh-support-python-3.7 branch from 9bc9d3f to 84cfe18 Compare November 15, 2019 16:39
@lexi-lambda lexi-lambda merged commit ec6df7c into hasura:master Nov 15, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 15, 2019

Review app https://hge-ci-pull-3356.herokuapp.com is deleted

@jberryman jberryman deleted the issue-3312-dev.sh-support-python-3.7 branch November 15, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lexi-lambda lexi-lambda lexi-lambda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jberryman @hasura-bot @lexi-lambda