Deploy preview for hasura-docs ready!

Built with commit 37f6791

https://deploy-preview-3347--hasura-docs.netlify.com

Review app for commit 08e7ed0 deployed to Heroku: https://hge-ci-pull-3347.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3347-08e7ed07

@tirumaraiselvan The tests you just pushed seem to be failing.

Bit of a conundrum. The server in CI seems to be running in localhost:8081.

@lexi-lambda I am thinking of dropping the test for X-Forwarded-Host as it is dynamic ( but I will keep X-Forwarded-User-Agent) ?

Ah, yeah, the tests in CI spin up two instances of graphql-engine in parallel. There must be a way to access the current host and port we’re running the tests against from inside the test suite code, so we should use that for the expected value of X-Forwarded-Host.

We can get the host:port in pytest but the expected value will then somehow will have to be fed to the graphql_server.py (which so far was independent server). Worth the fight?

Ah, I see, right of course. I think it’s probably worth doing—graphql-server.py will need to check to see if the host is either of the expected GraphQL servers, so it should probably be fed a list of URLs the same way the core test suite is.

Review app for commit b787bbe deployed to Heroku: https://hge-ci-pull-3347.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3347-b787bbec

Review app for commit 1d70c47 deployed to Heroku: https://hge-ci-pull-3347.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3347-1d70c479

Wow awkwardly stumbled on fixing this till I realized that there was only one pytest session but parallelized internally.

Review app for commit 37f6791 deployed to Heroku: https://hge-ci-pull-3347.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3347-37f6791e

Review app https://hge-ci-pull-3347.herokuapp.com is deleted