这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Nov 7, 2019

Description

This PR fixes an unhandled table configuration default.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

#3313 #3314 #3316

Solution and Design

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

Steps to test and verify

Limitations, known bugs & workarounds

@wawhal wawhal requested a review from rikinsk as a code owner November 7, 2019 02:32
@netlify
Copy link

netlify bot commented Nov 7, 2019

Deploy preview for hasura-docs ready!

Built with commit 453c9ed

https://deploy-preview-3317--hasura-docs.netlify.com

c0h1b4
c0h1b4 previously approved these changes Nov 7, 2019
@hasura-bot
Copy link
Contributor

Review app for commit b7418c5 deployed to Heroku: https://hge-ci-pull-3317.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3317-b7418c52

@rikinsk rikinsk merged commit 3a07b2b into hasura:master Nov 7, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3317.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants