这是indexloc提供的服务，不要输入任何密码
Skip to content

console: allow custom mutations through actions #3252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 87 commits into from
Closed

console: allow custom mutations through actions #3252

wants to merge 87 commits into from

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Oct 26, 2019 •
edited
Loading

Description

This PR implements a UI for creating actions and managing types.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

Steps to test and verify

Limitations, known bugs & workarounds

@wawhal wawhal added the s/do-not-merge Do not merge this pull request to master label Oct 26, 2019
@netlify
Copy link

netlify bot commented Oct 26, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 6fcf729

https://deploy-preview-3252--hasura-docs.netlify.com

@hasura hasura deleted a comment from wawhal Oct 27, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 28, 2019

Review app for commit ea7d23a deployed to Heroku: https://hge-ci-pull-3252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3252-ea7d23ae

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 30, 2019

Review app for commit fa94331 deployed to Heroku: https://hge-ci-pull-3252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3252-fa94331b

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 30, 2019

Review app for commit 7cb5faa deployed to Heroku: https://hge-ci-pull-3252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3252-7cb5faa8

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 30, 2019

Review app for commit e49778d deployed to Heroku: https://hge-ci-pull-3252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3252-e49778d0

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 6, 2020

Review app for commit 274cbeb deployed to Heroku: https://hge-ci-pull-3252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3252-274cbeb6

@wawhal wawhal requested a review from beerose February 7, 2020 07:02
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 7, 2020

Review app for commit 8b016f8 deployed to Heroku: https://hge-ci-pull-3252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3252-8b016f86

beerose
beerose reviewed Feb 7, 2020
View reviewed changes
@beerose
Copy link
Contributor

beerose commented Feb 7, 2020

If I want to add a relationship and don't fill some required type, eg. name, I'm getting an error is not valid GraphQL name. But then, if I fill the name properly, there's still the same error, and filled value is not sent to the backend.

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 7, 2020

Review app for commit 480849a deployed to Heroku: https://hge-ci-pull-3252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3252-480849a0

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 10, 2020

Review app for commit f83ccf1 deployed to Heroku: https://hge-ci-pull-3252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3252-f83ccf1e

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 10, 2020

Review app for commit 70162ba deployed to Heroku: https://hge-ci-pull-3252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3252-70162ba7

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 10, 2020

Review app for commit 7073dec deployed to Heroku: https://hge-ci-pull-3252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3252-7073dece

@SidhNor
Copy link

SidhNor commented Feb 10, 2020

Do you have a planned date for the release of this along with all related functionality?

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 12, 2020

Review app for commit 2c9d1fe deployed to Heroku: https://hge-ci-pull-3252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3252-2c9d1fe0

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 12, 2020

Review app for commit 8f3cdcb deployed to Heroku: https://hge-ci-pull-3252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3252-8f3cdcb1

@RodolfoSilva
Copy link
Contributor

RodolfoSilva commented Feb 12, 2020

@wawhal hi, good job.

I have a question about Codegen, will they also generate the Postgres function?

@wawhal
Copy link
Contributor Author

wawhal commented Feb 13, 2020

@SidhNor we are planning to release in the next couple of days.
@RodolfoSilva postgres functions are not supported yet.

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 13, 2020

Review app for commit 21cc0ef deployed to Heroku: https://hge-ci-pull-3252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3252-21cc0efb

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 14, 2020

Review app for commit c02fbfe deployed to Heroku: https://hge-ci-pull-3252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3252-c02fbfe3

@wawhal
Copy link
Contributor Author

wawhal commented Mar 4, 2020

Closing this preview PR. Actions is now available in beta.

@wawhal wawhal closed this Mar 4, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 4, 2020

Review app https://hge-ci-pull-3252.herokuapp.com is deleted

@RodolfoSilva
Copy link
Contributor

RodolfoSilva commented Mar 4, 2020

@wawhal have any plan/schedule to add support to postgres function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@beerose beerose beerose left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

s/do-not-merge Do not merge this pull request to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@wawhal @hasura-bot @weyert @beerose @SidhNor @RodolfoSilva @rikinsk @arvi3411301