这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@karthikvt26
Copy link
Contributor

@karthikvt26 karthikvt26 commented Aug 28, 2018

Adds metadata export/import via console. Merges #311

@coco98 @praveenweb. Kindly review and let me know if anything needs to be changed.

aswinmprabhu and others added 30 commits July 16, 2018 12:16
@praveenweb
Copy link
Member

@karthikvt26 - static assets (images) are referenced from rstatic/dist which cannot be served by graphql-engine server or cli. These images need to come from CDN link (google storage).

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-323.herokuapp.com

@coco98
Copy link
Contributor

coco98 commented Sep 5, 2018

@karthikvt26 Many small issues:

  1. Link only works if I click on text and not on the entire tab
  2. Metadata page has a weird left/right padding
  3. Metadata icon is not actually a dropdown, but it's a page. That means it should have the yellow highlighted page styling
  4. Twitter message should be
Just deployed a GraphQL backend with @HasuraHQ! ❤️ 🚀
https://github.com/hasura/graphql-engine

#graphql #postgres
  1. I'm not sure about having different colours:

screen shot 2018-09-05 at 12 59 23 pm

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-323.herokuapp.com

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-323.herokuapp.com

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-323.herokuapp.com

1 similar comment
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-323.herokuapp.com

* add a query to reload schema cache (metadata), close hasura#292

* minor code refactor

* simpler root level select fields using primary keys (fix hasura#304) (hasura#306)

* select fields by primary key col values as argument values, fix hasura#304

* change field name 'table_by_pkey' to 'table_by_pk'

* add links to share and help (hasura#303)

* add req_user_id as alias to x-hasura-user-id (fix hasura#317) (hasura#320)

* fix insert fails for non-admin roles on v1/query  (fix hasura#327) (hasura#328)

* fix insert fails for non-admin roles on v1/query, fix hasura#327

* add test case for user role upsert usint constraint name

* mutation return type and query type are same (close hasura#315) (hasura#324)

* add support for jwt authorization (close hasura#186) (hasura#255)

The API:
1. HGE has `--jwt-secret` flag or `HASURA_GRAPHQL_JWT_SECRET` env var. The value of which is a JSON.

2. The structure of this JSON is: `{"type": "<standard-JWT-algorithms>", "key": "<the-key>"}`
`type` : Standard JWT algos : `HS256`, `RS256`, `RS512` etc. (see jwt.io).
`key`:
  i. Incase of symmetric key, the key as it is.
  ii. Incase of asymmetric keys, only the public key, in a PEM encoded string or as a X509 certificate.

3. The claims in the JWT token must contain the following:
  i. `x-hasura-default-role` field: default role of that user
  ii. `x-hasura-allowed-roles` : A list of allowed roles for the user. The default role is overriden by `x-hasura-role` header.

4. The claims in the JWT token,  can have other `x-hasura-*` fields where their values can only be strings.

5. The JWT tokens are sent as `Authorization: Bearer <token>` headers.

---
To test:
1. Generate a shared secret (for HMAC-SHA256) or RSA key pair.
2. Goto https://jwt.io/ , add the keys
3. Edit the claims to have `x-hasura-role` (mandatory) and other `x-hasura-*` fields. Add permissions related to the claims to test permissions.
4. Start HGE with `--jwt-secret` flag or `HASURA_GRAPHQL_JWT_SECRET` env var, which takes a JSON string: `{"type": "HS256", "key": "mylongsharedsecret"}` or `{"type":"RS256", "key": "<PEM-encoded-public-key>"}`
5. Copy the JWT token from jwt.io and use it in the `Authorization: Bearer <token>` header.

---
TODO: Support EC public keys. It is blocked on frasertweedale/hs-jose#61

* compare only major and minor versions for cli-server (fix hasura#331) (hasura#332)

* Revert "add links to share and help (hasura#303)" (hasura#334)

This reverts commit 798efdd.

* update tests to use access key (close hasura#113) (hasura#296)

Closes hasura#113

* generate a returning field in a mutation only when the select permission is defined (fix hasura#340) (hasura#341)

* allow selectively updating columns on a conflict during insert (fix hasura#342)

* fix primary key changing on upsert, fix hasura#342

* add 'update_columns' in 'on_conflict' object, consider 'allowUpsert'

* 'ConflictCtx' type should respect upsert cases

* validation for not null fields in an object

* console: fix error notification non json, auto height css (hasura#354)
@shahidhk shahidhk added c/console Related to console c/server Related to server s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Sep 5, 2018
@karthikvt26
Copy link
Contributor Author

@praveenweb I have added the version check. Please review it once and provide feedback.

@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-323.herokuapp.com

1 similar comment
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-323.herokuapp.com

Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk merged commit e3102df into hasura:master Sep 5, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-323.herokuapp.com is deleted

hasura-bot added a commit that referenced this pull request Jan 11, 2021
* Enables OSS CI in beta branch

* updates server_builder_image

* server: hasura on PG v13

cherry pick of 00fd91c

Co-authored-by: hasura-bot <accounts@hasura.io>
GitOrigin-RevId: 67296c1255b676a6ce9c9499ccaedae1fd63e51a
hasura-bot pushed a commit that referenced this pull request Feb 23, 2024
This fixes a bug with collection_relationships not being populated by relationships constructed from where and/or order by clauses.

We fix this by not only collecting relationships from field selection, but also considering relationships introduced by order by and where clauses.

V3_GIT_ORIGIN_REV_ID: c612ceed8b3831257ca2c7d23ec9ed23261efedf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console c/server Related to server s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.