这是indexloc提供的服务，不要输入任何密码
Skip to content

add name to migrate status response (close #2376) #3109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 28, 2019
Merged

add name to migrate status response (close #2376) #3109

merged 10 commits into from
Nov 28, 2019

Conversation

@eulercb
Copy link
Contributor

@eulercb eulercb commented Oct 13, 2019

Description

Adds Identifier to CLI status command response.

Affected components

  • CLI

Related Issues

#2376

Solution and Design

The source Driver interface was extended to expose the Identifier.

Steps to test and verify

Before:
image

After:
image

Limitations, known bugs & workarounds

Should the IDENTIFIER column be on the rightmost place (see image above)? Maybe it should be placed next to VERSION.

@eulercb eulercb requested a review from shahidhk as a code owner October 13, 2019 01:04
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 13, 2019

Beep boop! 🤖

Hey @eulercamposbarros, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Oct 13, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit cd64977

https://deploy-preview-3109--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 13, 2019

Review app for commit 325b033 deployed to Heroku: https://hge-ci-pull-3109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3109-325b033b

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 13, 2019

Review app for commit c078516 deployed to Heroku: https://hge-ci-pull-3109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3109-c0785167

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 13, 2019

Review app for commit 8e28bb0 deployed to Heroku: https://hge-ci-pull-3109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3109-8e28bb0e

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 13, 2019

Review app for commit 2893a2d deployed to Heroku: https://hge-ci-pull-3109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3109-2893a2d3

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 13, 2019

Review app for commit ee7b0c1 deployed to Heroku: https://hge-ci-pull-3109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3109-ee7b0c19

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 13, 2019

Review app for commit 886db83 deployed to Heroku: https://hge-ci-pull-3109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3109-886db832

@eulercb
Copy link
Contributor Author

eulercb commented Oct 13, 2019

Sorry for the mess with all these commits. If this gets accepted, I suggest doing a squash merge to avoid clutter the git master's history.

@marionschleifer marionschleifer added c/cli Related to CLI c/community Related to community content labels Oct 14, 2019
@marionschleifer marionschleifer changed the title Add Identifier to migrate status response Add Identifier to migrate status response (close #2376) Nov 5, 2019
@marionschleifer
Copy link
Contributor

marionschleifer commented Nov 6, 2019

@eulercamposbarros could you please send an email to marion@hasura.io, so that we can arrange the shipping of your swag? 🙂

@shahidhk shahidhk requested a review from arvi3411301 November 20, 2019 08:48
arvi3411301
arvi3411301 requested changes Nov 20, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 22, 2019

Review app for commit 832767d deployed to Heroku: https://hge-ci-pull-3109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3109-832767d4

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 22, 2019

Review app for commit cd64977 deployed to Heroku: https://hge-ci-pull-3109.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3109-cd649775

@eulercb eulercb requested a review from arvi3411301 November 22, 2019 14:15
@shahidhk shahidhk changed the title Add Identifier to migrate status response (close #2376) add name to migrate status response (close #2376) Nov 28, 2019
@shahidhk shahidhk merged commit 56a217b into hasura:master Nov 28, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 28, 2019

Beep boop! 🤖

GIF

Awesome work @eulercamposbarros! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 28, 2019

Review app https://hge-ci-pull-3109.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@eulercb @polRk
add name to migrate status response (close hasura#2376) (hasura#3109)
96ead7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

@arvi3411301 arvi3411301 arvi3411301 approved these changes

Assignees

No one assigned

Labels

c/cli Related to CLI c/community Related to community content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eulercb @hasura-bot @CLAassistant @marionschleifer @shahidhk @arvi3411301