remove graphiql fork #3073

wawhal · 2019-10-09T10:36:31Z

Description

Currently we use a fork of GraphiQL. They did a major rehaul which does not let us pull the newer updates from upstream. This PR integrates GraphiQL fork with Hasura console and moves all our logic in the console code base

Affected components

Console

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

netlify · 2019-10-09T10:37:48Z

Deploy preview for hasura-docs ready!

Built with commit d62e1fe

https://deploy-preview-3073--hasura-docs.netlify.com

hasura-bot · 2019-10-09T11:28:54Z

Review app for commit 87a6bb7 deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-87a6bb75

hasura-bot · 2019-10-09T13:06:21Z

Review app for commit 3ce06e2 deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-3ce06e22

hasura-bot · 2019-10-09T14:03:23Z

Review app for commit 7d719b5 deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-7d719b5a

…ngine into remove-graphiql-fork-v2

hasura-bot · 2019-10-09T15:06:28Z

Review app for commit 89dba85 deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-89dba85e

hasura-bot · 2019-10-10T05:54:18Z

Review app for commit 6c07eb3 deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-6c07eb34

…ngine into remove-graphiql-fork-v2

hasura-bot · 2019-10-10T08:27:37Z

Review app for commit d04b88a deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-d04b88a3

wawhal · 2019-10-11T08:32:54Z

/heroku deploy

rikinsk · 2019-10-11T10:27:55Z

/heroku deploy

hasura-bot · 2019-10-11T10:28:54Z

Review app for commit 3d88ba4 deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-3d88ba47

hasura-bot · 2019-10-11T10:35:41Z

Review app for commit 4a63806 deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-4a63806f

hasura-bot · 2019-10-12T06:07:23Z

Review app for commit 3c16483 deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-3c164838

hasura-bot · 2019-10-22T13:54:00Z

Review app for commit ca1c027 deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-ca1c0270

hasura-bot · 2019-10-24T08:28:23Z

Review app for commit d62e1fe deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-d62e1fe8

hasura-bot · 2020-01-27T12:38:35Z

Review app for commit b600425 deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-b6004258

beerose

I left some comments. Apart from them there is one CSS issue I noticed:

console/src/components/Services/ApiExplorer/Analyzer/AnalyzeButton.js

beerose · 2020-01-27T16:00:54Z

console/src/components/Services/ApiExplorer/Analyzer/QueryAnalyzer.js

+  handleAnalyseNodeChange(e) {
+    let nodeKey = e.target.getAttribute('data-key');
+    if (nodeKey) {
+      nodeKey = parseInt(nodeKey, 10);


It's not a big deal, but let's not mutate here and just make new constant:

const nodeKey = e.target.getAttribute('data-key'); if (nodeKey) { const parsedNodeKey = parseInt(nodeKey, 10);

console/src/components/Services/ApiExplorer/ApiCollectionPanel/ApiCollectionPanel.js

console/src/components/Services/ApiExplorer/GraphiQLWrapper/GraphiQLWrapper.js

hasura-bot · 2020-01-27T19:10:25Z

Review app for commit 4433862 deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-4433862f

console/src/components/Services/ApiExplorer/Analyzer/AnalyzeButton.js

console/src/components/Services/ApiExplorer/utils.js

hasura-bot · 2020-01-27T19:35:45Z

Review app for commit 413464b deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-413464b1

hasura-bot · 2020-01-27T20:18:17Z

Review app for commit 061c5ad deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-061c5adb

hasura-bot · 2020-01-29T14:47:38Z

Review app for commit b2d7211 deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-b2d72119

hasura-bot · 2020-01-31T11:37:41Z

Review app for commit 2111ee5 deployed to Heroku: https://hge-ci-pull-3073.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3073-2111ee53

hasura-bot · 2020-01-31T11:54:22Z

Review app https://hge-ci-pull-3073.herokuapp.com is deleted

…glify with terser (hasura#3073)

remove graphiql fork

1a04b46

wawhal requested a review from rikinsk as a code owner October 9, 2019 10:36

wawhal added c/console Related to console k/enhancement New feature or improve an existing feature labels Oct 9, 2019

integrate voyager and explorer

87a6bb7

trigger rebuild

3ce06e2

Merge branch 'master' into remove-graphiql-fork-v2

7d719b5

Rishichandra Wawhal added 2 commits October 9, 2019 20:04

revert graphiql logo

a334001

Merge branch 'remove-graphiql-fork-v2' of github.com:wawhal/graphql-e…

89dba85

…ngine into remove-graphiql-fork-v2

Merge branch 'master' into remove-graphiql-fork-v2

6c07eb3

Rishichandra Wawhal added 2 commits October 10, 2019 13:14

copy query elegantly

757f76f

Merge branch 'remove-graphiql-fork-v2' of github.com:wawhal/graphql-e…

d04b88a

…ngine into remove-graphiql-fork-v2

revert graphiql-explorer

3d88ba4

Merge branch 'master' into remove-graphiql-fork-v2

4a63806

Merge branch 'master' into remove-graphiql-fork-v2

3c16483

Merge branch 'master' into remove-graphiql-fork-v2

ca1c027

Merge branch 'master' into remove-graphiql-fork-v2

d62e1fe

merge with master

b600425

beerose reviewed Jan 27, 2020

View reviewed changes

work on requested changes

4433862

beerose reviewed Jan 27, 2020

View reviewed changes

console/src/components/Services/ApiExplorer/Analyzer/AnalyzeButton.js Outdated Show resolved Hide resolved

move graphql operation validator to utils; remove unnecessary spread

413464b

beerose reviewed Jan 27, 2020

View reviewed changes

console/src/components/Services/ApiExplorer/utils.js Show resolved Hide resolved

fix tab title overflow in graphiql; fix unnecessary variable mutation

061c5ad

beerose previously approved these changes Jan 27, 2020

View reviewed changes

upgrade graphiql

f78f05d

beerose dismissed their stale review via f78f05d January 29, 2020 13:02

replace uglify-js webpack plugin with terser

b2d7211

beerose approved these changes Jan 30, 2020

View reviewed changes

Merge branch 'master' into remove-graphiql-fork-v2

2111ee5

rikinsk approved these changes Jan 31, 2020

View reviewed changes

rikinsk merged commit 405d645 into hasura:master Jan 31, 2020

rikinsk mentioned this pull request Feb 5, 2020

extend support for subscriptions in 'analyze' #2541

Closed

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020

console: replace graphiql fork with pkg + update explorer + replace u…

dae193c

…glify with terser (hasura#3073)

remove graphiql fork #3073

remove graphiql fork #3073

Uh oh!

Conversation

wawhal commented Oct 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Affected components

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Uh oh!

netlify bot commented Oct 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hasura-bot commented Oct 9, 2019

Uh oh!

hasura-bot commented Oct 9, 2019

Uh oh!

hasura-bot commented Oct 9, 2019

Uh oh!

hasura-bot commented Oct 9, 2019

Uh oh!

hasura-bot commented Oct 10, 2019

Uh oh!

hasura-bot commented Oct 10, 2019

Uh oh!

wawhal commented Oct 11, 2019

Uh oh!

rikinsk commented Oct 11, 2019

Uh oh!

hasura-bot commented Oct 11, 2019

Uh oh!

hasura-bot commented Oct 11, 2019

Uh oh!

hasura-bot commented Oct 12, 2019

Uh oh!

hasura-bot commented Oct 22, 2019

Uh oh!

hasura-bot commented Oct 24, 2019

Uh oh!

hasura-bot commented Jan 27, 2020

Uh oh!

beerose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

beerose Jan 27, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hasura-bot commented Jan 27, 2020

Uh oh!

Uh oh!

Uh oh!

hasura-bot commented Jan 27, 2020

Uh oh!

hasura-bot commented Jan 27, 2020

Uh oh!

hasura-bot commented Jan 29, 2020

Uh oh!

hasura-bot commented Jan 31, 2020

Uh oh!

hasura-bot commented Jan 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

wawhal commented Oct 9, 2019 •

edited

Loading

netlify bot commented Oct 9, 2019 •

edited

Loading