allow custom mutations through actions #3042

0x777 · 2019-10-06T18:10:57Z

Needs hasura/graphql-parser-hs#19 to be merged

I'll be pushing changes to this PR over the next couple of days. A high level overview of actions can be found in this PR's docs.

Updated: 23/10/2019

Tasks done:

Remaining:

pg functions as action handlers
async action relationships

update_action:-

type: update_action
args:
  name: action-name
  definition: action-definition # will replaces existing one

The webhook is called over POST. The payload looks like:-

{
  "session_variables": {
    "x-hasura-user-id": "1234"
  },
  "input": {
    "arg1": "value1",
    "arg2": "value2"
  },
  "action": {
    "name": "action-name"
  }
}

The webhook response:

On success, should return a 2xx code with JSON body whose value is of the defined output type
Should return a 4xx code for an error that should be propagated back to the client. The response JSON body is an object with a compulsory message field (text) and optional code field (text)
All other status codes are treated as internal errors and nothing is propagated to the client. The details should be logged as internal in error field and part of extensions in response for the admin role.

Single row mutations:- Implemented the RFC #3731

netlify · 2019-10-06T18:12:20Z

Deploy preview for hasura-docs ready!

Built with commit 8323c30

https://deploy-preview-3042--hasura-docs.netlify.com

0x777 · 2019-10-06T18:13:39Z

https://deploy-preview-3042--hasura-docs.netlify.com/graphql/manual/actions/index.html

hasura-bot · 2019-10-06T18:19:41Z

Review app for commit a786aed deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-a786aed5

hasura-bot · 2019-10-14T05:27:25Z

Review app for commit af6139e deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-af6139ec

hasura-bot · 2019-10-14T13:14:51Z

Review app for commit 5d58513 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-5d58513d

…uilder image

hasura-bot · 2019-10-21T04:09:24Z

Review app for commit 4bc8106 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-4bc81068

hasura-bot · 2019-10-21T05:45:33Z

Review app for commit c86dcc4 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-c86dcc46

hasura-bot · 2019-10-24T10:23:08Z

Review app for commit ea0f8f7 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-ea0f8f70

hasura-bot · 2019-10-24T11:48:57Z

Review app for commit a40b68e deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-a40b68e7

hasura-bot · 2019-10-24T15:41:44Z

Review app for commit c33372a deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-c33372a8

server/src-lib/Hasura/RQL/DDL/Action.hs

server/src-lib/Hasura/RQL/Types/Action.hs

hasura-bot · 2020-02-09T13:03:20Z

Review app for commit a0771e0 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-a0771e0a

SidhNor · 2020-02-10T13:37:32Z

Thank your for great effort out there. This looks awesome.
When do you think this can realistically get into beta?

hasura-bot · 2020-02-10T15:42:54Z

Review app for commit a3e2805 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-a3e2805a

hasura-bot · 2020-02-10T16:17:30Z

Review app for commit 06b35e6 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-06b35e62

server/src-lib/Hasura/GraphQL/Context.hs

…-hs lib git reference

hasura-bot · 2020-02-11T10:40:43Z

Review app for commit c96dd6e deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-c96dd6eb

Resolve Conflicts: server/src-lib/Hasura/SQL/Types.hs

hasura-bot · 2020-02-11T13:09:50Z

Review app for commit 2e92e3a deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-2e92e3a6

hasura-bot · 2020-02-12T09:05:50Z

Review app for commit 20e23a1 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-20e23a1c

hasura-bot · 2020-02-13T06:45:57Z

Review app for commit e32545e deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-e32545ed

Resolve Conflicts: server/src-lib/Hasura/GraphQL/Resolve/Insert.hs server/src-lib/Hasura/GraphQL/Resolve/Mutation.hs server/src-lib/Hasura/RQL/DML/Insert.hs server/src-lib/Hasura/RQL/DML/Update.hs server/src-lib/Hasura/RQL/Types/SchemaCache.hs

hasura-bot · 2020-02-13T08:29:01Z

Review app for commit 9222cae deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-9222cae1

hasura-bot · 2020-02-13T09:27:16Z

Review app for commit 8a07237 deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-8a07237c

hasura-bot · 2020-02-13T10:00:16Z

Review app for commit 12dc26e deployed to Heroku: https://hge-ci-pull-3042.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3042-12dc26e4

hasura-bot · 2020-02-13T17:38:26Z

Review app https://hge-ci-pull-3042.herokuapp.com is deleted

lukaspili mentioned this pull request Oct 11, 2019

Could we have PRE event-trigger for customize data validation? #1291

Closed

0x777 and others added 11 commits October 15, 2019 20:28

basic doc for actions

b3ac563

wip docs

8946ba7

wip: custom_types, sync and async actions

05684e8

switch to graphql-parser-hs on github

61072b1

update docs

04b863c

metadata import/export

afb4ac9

webhook calls are now supported

a7d72ac

relationships in sync actions

ca4fd66

revert to lts-13 and bump graphql-parser-hs commit

4462284

lower the lts version so that the Cabal version matches that of the b…

e0570a5

…uilder image

disable -Werr on this branch

4bc8106

initialise.sql is now in sync with the migration file

c86dcc4

0x777 added 2 commits October 21, 2019 16:02

fix metadata tests

cb05dd1

allow specifying arguments of actions

b925752

hasura deleted a comment from wawhal Oct 24, 2019

fix blacklist check on check_build_worthiness job

ea0f8f7

track custom_types and actions related tables

a40b68e

handlers are now triggered on async actions

c33372a

rakeshkky reviewed Feb 7, 2020

View reviewed changes

server/src-lib/Hasura/RQL/DDL/Action.hs Outdated Show resolved Hide resolved

rakeshkky reviewed Feb 7, 2020

View reviewed changes

server/src-lib/Hasura/RQL/Types/Action.hs Outdated Show resolved Hide resolved

rakeshkky reviewed Feb 7, 2020

View reviewed changes

server/src-lib/Hasura/RQL/Types/Action.hs Outdated Show resolved Hide resolved

incorporate review suggestion by @0x777

a0771e0

document async action architecture in Resolve/Action.hs file

a3e2805

rakeshkky added 2 commits February 10, 2020 21:20

remove few commented code

5b2de9a

Merge branch 'master' into actions

06b35e6

0x777 commented Feb 11, 2020

View reviewed changes

server/src-lib/Hasura/GraphQL/Context.hs Outdated Show resolved Hide resolved

remove commented code from GraphQL/Context.hs & update graphql-parser…

c96dd6e

…-hs lib git reference

rakeshkky added 2 commits February 11, 2020 16:36

Merge branch 'master' into actions

57f71e8

Resolve Conflicts: server/src-lib/Hasura/SQL/Types.hs

remove a non exhaustive pattern matches

2e92e3a

rakeshkky added 2 commits February 12, 2020 12:17

support actions returning array of objects

c3557ea

tests for list type response actions

20e23a1

update docs with actions and custom types metadata API reference

e32545e

Merge branch 'master' into actions

9222cae

Resolve Conflicts: server/src-lib/Hasura/GraphQL/Resolve/Insert.hs server/src-lib/Hasura/GraphQL/Resolve/Mutation.hs server/src-lib/Hasura/RQL/DML/Insert.hs server/src-lib/Hasura/RQL/DML/Update.hs server/src-lib/Hasura/RQL/Types/SchemaCache.hs

Merge branch 'master' into actions

8a07237

update actions python tests as per #f8e1330

12dc26e

0x777 merged commit b84db36 into hasura:master Feb 13, 2020

allow custom mutations through actions #3042

allow custom mutations through actions #3042

Uh oh!

Conversation

0x777 commented Oct 6, 2019 • edited by rakeshkky Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Updated: 23/10/2019

Uh oh!

netlify bot commented Oct 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0x777 commented Oct 6, 2019

Uh oh!

hasura-bot commented Oct 6, 2019

Uh oh!

hasura-bot commented Oct 14, 2019

Uh oh!

hasura-bot commented Oct 14, 2019

Uh oh!

hasura-bot commented Oct 21, 2019

Uh oh!

hasura-bot commented Oct 21, 2019

Uh oh!

hasura-bot commented Oct 24, 2019

Uh oh!

hasura-bot commented Oct 24, 2019

Uh oh!

hasura-bot commented Oct 24, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hasura-bot commented Feb 9, 2020

Uh oh!

SidhNor commented Feb 10, 2020

Uh oh!

hasura-bot commented Feb 10, 2020

Uh oh!

hasura-bot commented Feb 10, 2020

Uh oh!

Uh oh!

hasura-bot commented Feb 11, 2020

Uh oh!

hasura-bot commented Feb 11, 2020

Uh oh!

hasura-bot commented Feb 12, 2020

Uh oh!

hasura-bot commented Feb 13, 2020

Uh oh!

hasura-bot commented Feb 13, 2020

Uh oh!

hasura-bot commented Feb 13, 2020

Uh oh!

hasura-bot commented Feb 13, 2020

Uh oh!

hasura-bot commented Feb 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

0x777 commented Oct 6, 2019 •

edited by rakeshkky

Loading

netlify bot commented Oct 6, 2019 •

edited

Loading