这是indexloc提供的服务，不要输入任何密码
Skip to content

Accept query params for filter/sort in browse table page (close #833) #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 5, 2020
Merged

Accept query params for filter/sort in browse table page (close #833) #3041

merged 8 commits into from
Feb 5, 2020

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Oct 6, 2019

Description

Affected components

  • Console

Related Issues

#833

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@feloy feloy requested a review from rikinsk as a code owner October 6, 2019 14:38
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 6, 2019

Beep boop! 🤖

Hey @feloy, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Oct 6, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 9afe08c

https://deploy-preview-3041--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 6, 2019

Review app for commit 983db03 deployed to Heroku: https://hge-ci-pull-3041.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3041-983db038

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 6, 2019

Review app for commit 6022a79 deployed to Heroku: https://hge-ci-pull-3041.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3041-6022a791

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 6, 2019

Review app for commit 699c8e4 deployed to Heroku: https://hge-ci-pull-3041.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3041-699c8e4e

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 6, 2019

Review app for commit c4e9a35 deployed to Heroku: https://hge-ci-pull-3041.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3041-c4e9a35e

@marionschleifer marionschleifer added c/console Related to console c/community Related to community content labels Oct 6, 2019
@feloy feloy changed the title WIP: accept query params for filter/sort in browse table page (close #833) Accept query params for filter/sort in browse table page (close #833) Oct 6, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 6, 2019

Review app for commit 9afe08c deployed to Heroku: https://hge-ci-pull-3041.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3041-9afe08ce

@feloy
Copy link
Contributor Author

feloy commented Oct 19, 2019

Hi @rikinsk , any thought on this PR?

@rikinsk
Copy link
Member

rikinsk commented Oct 21, 2019

@feloy Sorry for the delay in this. Will get around to reviewing this in a day or two.

@marionschleifer marionschleifer added community-contrib 🙏🏽 and removed c/community Related to community content labels Dec 24, 2019
beerose
beerose suggested changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @feloy 👋
Thanks for the PR, and sorry for the delay in reviewing this.

I tested your PR, and all is working fine, but I left some comments regarding implementation.

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 5, 2020

Review app for commit 4bd3e54 deployed to Heroku: https://hge-ci-pull-3041.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3041-4bd3e542

@beerose beerose self-requested a review February 5, 2020 08:42
beerose
beerose previously approved these changes Feb 5, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 5, 2020

Review app for commit 2c74ee6 deployed to Heroku: https://hge-ci-pull-3041.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3041-2c74ee6c

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 5, 2020

Review app for commit eea9f4c deployed to Heroku: https://hge-ci-pull-3041.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3041-eea9f4c4

@rikinsk rikinsk merged commit 70e1b77 into hasura:master Feb 5, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 5, 2020

Beep boop! 🤖

GIF

Awesome work @feloy! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 5, 2020

Review app https://hge-ci-pull-3041.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 5, 2020

Review app for commit 779b5c0 deployed to Heroku: https://hge-ci-pull-3041.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3041-779b5c01

rikinsk pushed a commit that referenced this pull request Feb 5, 2020
handle missed edge-cases introduced in #3041 (#3837)
f834f6b
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@feloy @polRk
accept query params for filter/sort in browse table page (close hasur…
a0cba9c 
…a#833) (hasura#3041)
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@polRk
handle missed edge-cases introduced in hasura#3041 (hasura#3837)
f6e4902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/console Related to console community-contrib 🙏🏽

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@feloy @hasura-bot @CLAassistant @rikinsk @beerose @marionschleifer