fixes to the subscriptions improvements introduced with #2942 #3005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 6b951d2 |
Contributor
|
Review app for commit acc7f8a deployed to Heroku: https://hge-ci-pull-3005.herokuapp.com |
lexi-lambda
approved these changes
Oct 3, 2019
Contributor
|
Review app for commit 6b951d2 deployed to Heroku: https://hge-ci-pull-3005.herokuapp.com |
marionschleifer
approved these changes
Oct 3, 2019
Contributor
|
Review app https://hge-ci-pull-3005.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
…asura#3005) * fix incorrect references to result variables * remove docs/code related to 'fallback' backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The json encoding of result variables changed but the corresponding references weren't changed (we should probably be enforcing the above constraint with the type system). I'm surprised that our current testing framework didn't catch this; it definitely needs to be expanded to cover permissions (queries have such tests).