这是indexloc提供的服务，不要输入任何密码
Skip to content

chore: fixed lint issues, code standardization, code formatting #3028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 7, 2019
Merged

chore: fixed lint issues, code standardization, code formatting #3028

merged 13 commits into from
Oct 7, 2019

Conversation

@KirankumarAmbati
Copy link
Contributor

@KirankumarAmbati KirankumarAmbati commented Oct 5, 2019

Description

  • Fixed Lint issues
  • Code formatting
  • Component standardization

Affected components

  • Console

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 5, 2019

Beep boop! 🤖

Hey @KirankumarAmbati, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@netlify
Copy link

netlify bot commented Oct 5, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 9b3cdba

https://deploy-preview-3028--hasura-docs.netlify.com

@KirankumarAmbati
Copy link
Contributor Author

KirankumarAmbati commented Oct 5, 2019

CC: @shahidhk

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 5, 2019

Review app for commit 07825a5 deployed to Heroku: https://hge-ci-pull-3028.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3028-07825a5a

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 5, 2019

Review app for commit db06789 deployed to Heroku: https://hge-ci-pull-3028.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3028-db067893

@marionschleifer marionschleifer added c/console Related to console c/community Related to community content labels Oct 6, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 7, 2019

Review app for commit 9b3cdba deployed to Heroku: https://hge-ci-pull-3028.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3028-9b3cdbab

@rikinsk rikinsk merged commit 3d4f285 into hasura:master Oct 7, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 7, 2019

Review app https://hge-ci-pull-3028.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 7, 2019

Beep boop! 🤖

GIF

Awesome work @KirankumarAmbati! All of us at Hasura ❤️ what you did.

Thanks again 🤗

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@KirankumarAmbati @polRk
fix console lint issues, code formatting (hasura#3028)
bf51d11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

Assignees

No one assigned

Labels

c/community Related to community content c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KirankumarAmbati @hasura-bot @rikinsk @marionschleifer