add relationship name to generated order_by field names (fix #2981) #2998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit b6c07fd |
Contributor
|
Review app for commit ced467e deployed to Heroku: https://hge-ci-pull-2998.herokuapp.com |
lexi-lambda
approved these changes
Oct 4, 2019
Contributor
|
Review app for commit 47819b5 deployed to Heroku: https://hge-ci-pull-2998.herokuapp.com |
Contributor
|
Review app for commit 4c9bb58 deployed to Heroku: https://hge-ci-pull-2998.herokuapp.com |
Contributor
|
Review app for commit b6c07fd deployed to Heroku: https://hge-ci-pull-2998.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-2998.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug related to SQL generation while more than one aggregate order_by of different array relationships present in the query. For more details refer to issue #2981
Affected components
Related Issues
fix #2981
Solution and Design
In
selectSQL generation, all order_by s are marked with field nameorder_by. So, two aggregate order_bys from different array relationships are treated the same and their subqueries are merged. Hence,postgres query erroris being thrown.This PR generates order_by field names as
<relationshp-name>.order_byto distinguish between different relationships.Steps to test and verify
Follow the reproduction given in #2981 and make sure the query passes through
Limitations, known bugs & workarounds
N/A