这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@LiTO773
Copy link
Contributor

@LiTO773 LiTO773 commented Oct 2, 2019

Description

Added an 'echo' nodejs example to the Netlify functions boilerplates, along with the respective README.md. I also fixed a small typo.
This will allow a Netlify functions user to easily deploy a sample event trigger on the platform.

Affected components

  • Community Content

Related Issues

#431

Steps to test and verify

Follow the steps in the newly provided README.md and deploy to Netlify.

@LiTO773 LiTO773 requested a review from shahidhk as a code owner October 2, 2019 15:04
@CLAassistant
Copy link

CLAassistant commented Oct 2, 2019

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Oct 2, 2019

Deploy preview for hasura-docs ready!

Built with commit f1ccc54

https://deploy-preview-2985--hasura-docs.netlify.com

@marionschleifer marionschleifer added the c/community Related to community content label Oct 2, 2019
@LiTO773
Copy link
Contributor Author

LiTO773 commented Oct 9, 2019

@shahidhk @praveenweb please check it when you can 😄

@LiTO773
Copy link
Contributor Author

LiTO773 commented Oct 26, 2019

When will this pull request be reviewed?

@marionschleifer
Copy link
Contributor

@LiTO773 thank you for your contribution 🙂 we'll review your PR asap. Meanwhile, could you please send an email to marion@hasura.io, so that we can arrange the shipping of your swag?

@praveenweb praveenweb added the s/ok-to-merge Status: This pull request can be merged to master label Dec 30, 2019
@shahidhk shahidhk changed the title Added Netlify event-trigger 'echo' boilerplate (fix #431) community: add netlify event-trigger echo boilerplate (fix #431) Dec 30, 2019
@shahidhk shahidhk changed the title community: add netlify event-trigger echo boilerplate (fix #431) community: add netlify event-trigger echo boilerplate Dec 30, 2019
@shahidhk shahidhk merged commit c86a824 into hasura:master Dec 30, 2019
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

GIF

Awesome work @LiTO773! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-2985.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
Co-authored-by: Praveen Durairaju <praveend.web@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/community Related to community content community-contrib 🙏🏽 s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants