这是indexloc提供的服务，不要输入任何密码
Skip to content

cli: add commands to manage inconsistent metadata (close #2766) #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 25, 2019
Merged

cli: add commands to manage inconsistent metadata (close #2766) #2973

merged 10 commits into from
Dec 25, 2019

Conversation

@pradeepmurugesan
Copy link
Contributor

@pradeepmurugesan pradeepmurugesan commented Oct 1, 2019 •
edited by shahidhk
Loading

Adds new commands to manage inconsistent metadata to the CLI:

hasura metadata inconsistency status
hasura metadata inconsistency list
hasura metadata inconsistency drop

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Oct 1, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit c8150d6

https://deploy-preview-2973--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 1, 2019

Review app for commit dd1c578 deployed to Heroku: https://hge-ci-pull-2973.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2973-dd1c5781

@marionschleifer marionschleifer changed the title added the drop inconsistent metadata command to the cli added the drop inconsistent metadata command to the cli (close #27660 Oct 1, 2019
@marionschleifer marionschleifer changed the title added the drop inconsistent metadata command to the cli (close #27660 added the drop inconsistent metadata command to the cli (close #2766) Oct 1, 2019
@marionschleifer marionschleifer added c/cli Related to CLI c/community Related to community content labels Oct 1, 2019
@pradeepmurugesan
Copy link
Contributor Author

pradeepmurugesan commented Oct 7, 2019

@shahidhk Kindly let me know if you got a chance to review

@pradeepmurugesan pradeepmurugesan force-pushed the 2766-DropInconsistentMetadataCli branch from dd1c578 to 41a9844 Compare October 17, 2019 09:32
@pradeepmurugesan pradeepmurugesan changed the title added the drop inconsistent metadata command to the cli (close #2766) add the drop inconsistent metadata command to the cli (close #2766) Oct 17, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 17, 2019

Review app for commit 41a9844 deployed to Heroku: https://hge-ci-pull-2973.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2973-41a9844e

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 20, 2019

Review app for commit dc9121f deployed to Heroku: https://hge-ci-pull-2973.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2973-dc9121fa

@marionschleifer marionschleifer added community-contrib 🙏🏽 and removed c/community Related to community content labels Dec 24, 2019
@shahidhk shahidhk changed the title add the drop inconsistent metadata command to the cli (close #2766) cli: add commands to manage inconsistent metadata (close #2766) Dec 25, 2019
shahidhk
shahidhk previously approved these changes Dec 25, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 25, 2019

Review app for commit 1c2b7f3 deployed to Heroku: https://hge-ci-pull-2973.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2973-1c2b7f3e

@shahidhk shahidhk merged commit dece69c into hasura:master Dec 25, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 25, 2019

Beep boop! 🤖

GIF

Awesome work @pradeepmurugesan! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 25, 2019

Review app https://hge-ci-pull-2973.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 25, 2019

Review app for commit c8150d6 deployed to Heroku: https://hge-ci-pull-2973.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2973-c8150d62

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@pradeepmurugesan @arvi3411301
@shahidhk @polRk
cli: add commands to manage inconsistent metadata (close hasura#2766) (…
0f10365 
…hasura#2973)

Co-authored-by: Aravind Shankar <face11301@gmail.com>
Co-authored-by: Shahidh K Muhammed <muhammedshahid.k@gmail.com>
hasura-bot pushed a commit that referenced this pull request May 31, 2022
@hasura-bot
Add Weeder, begin weeding (1/?)
a3031ae 
## Description

This PR adds a config file for [`weeder`](https://github.com/ocharles/weeder) to the `-mono` repository. `weeder` checks for dead code by building a call graph from the given entry points (currently every module named `Main` with a `main` function) and then marking every function _not_ in that call graph as dead code.

To avoid very large PRs, I'm going to tackle this in a series. This first PR adds the basic configuration, plus removes as many weeds as it took for me to realise this was going to become a very big PR. The PRs after this will largely be removing dead code, until the final PR that will add Weeder to the CI pipeline.

### Related Issues

This closes #2973.

## Affected components

- Server

PR-URL: hasura/graphql-engine-mono#4572
GitOrigin-RevId: ac8eaa9473e5ac1f16babcb35388694392d0d7dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk left review comments

Assignees

@arvi3411301 arvi3411301

Labels

c/cli Related to CLI community-contrib 🙏🏽

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pradeepmurugesan @CLAassistant @hasura-bot @shahidhk @marionschleifer @arvi3411301