这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@nizar-m
Copy link
Contributor

@nizar-m nizar-m commented Sep 26, 2019

fix #2946

Description

Combining hpc reports fail with the following error

hpc: the flag -N1 requires the program to be built with -threaded

Affected components

  • Build System

Related Issues

Solution and Design

unset GHRTS during hpc combine, and restore after hpc combine

Steps to test and verify

Check the hpc combine step of circleci

Limitations, known bugs & workarounds

@nizar-m nizar-m requested a review from shahidhk as a code owner September 26, 2019 10:15
@netlify
Copy link

netlify bot commented Sep 26, 2019

Deploy preview for hasura-docs ready!

Built with commit d3d46f0

https://deploy-preview-2947--hasura-docs.netlify.com

@nizar-m nizar-m added the s/do-not-merge Do not merge this pull request to master label Sep 26, 2019
@nizar-m
Copy link
Contributor Author

nizar-m commented Sep 27, 2019

hpc combine is working after removing the threads configuration.

@nizar-m nizar-m added c/build-system Related to the build-release system s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Sep 27, 2019
Copy link
Collaborator

@jberryman jberryman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me except for adding that comment!

@shahidhk shahidhk changed the title Fix hpc combine error (close #2946) fix hpc combine error (close #2946) Oct 2, 2019
Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk merged commit 44da458 into hasura:master Oct 2, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-2947.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
* Fix hpc combine error

* Do not perform ciignore

* xfail test jsonb_has_all

* Bring back ciignore

* Refer jsonb_has_all xfaul to the corresponding issue in graphql-engine-internal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/build-system Related to the build-release system s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

combining hpc reports is failing on circleci

5 participants