optimise brotli and gzip compression speed #2938
Conversation
|
Deploy preview for hasura-docs ready! Built with commit 891b875 |
4a2fa5f to
2892ac2
Compare
|
Review app for commit 2892ac2 deployed to Heroku: https://hge-ci-pull-2938.herokuapp.com |
lexi-lambda
left a comment
There was a problem hiding this comment.
This seems fine to me, aside from the minor style comment. This seems like something that could possibly benefit from being user-configurable, but given the tradeoffs in play, these values seem pretty generally-applicable, so I think it’s fine to keep them hardcoded for the moment and see if anyone asks for configurability.
2892ac2 to
891b875
Compare
|
Review app for commit 891b875 deployed to Heroku: https://hge-ci-pull-2938.herokuapp.com |
|
Closing this PR as its changes are going through #2967 |
|
Review app https://hge-ci-pull-2938.herokuapp.com is deleted |
Description
The default compression level is max bound for Brotli and Gzip. This PR reduces the compression level to
4for brotli and1for gzip. Refer to this article to learn more about compression speeds vs level.Affected components
Related Issues
N/A
Solution and Design
Use compression params for brotli and gzip compression.
Steps to test and verify
Add onegraph as a remote schema and check the introspection query time in console.
Limitations, known bugs & workarounds