remove brotli compression #2967
Conversation
|
Deploy preview for hasura-docs ready! Built with commit 08570c8 |
|
Review app for commit 82aff91 deployed to Heroku: https://hge-ci-pull-2967.herokuapp.com |
82aff91 to
0034e82
Compare
|
Review app for commit 0034e82 deployed to Heroku: https://hge-ci-pull-2967.herokuapp.com |
server/tests-py/test_compression.py
Outdated
| # def test_brotli_compression_v1_query(self, hge_ctx): | ||
| # url, q, exp_resp = self._get_config(self.dir() + '/v1_query.yaml') | ||
| # resp = self._make_post(hge_ctx, url, q, self.brotli_header) | ||
| # self._assert_brotli(resp, exp_resp) |
There was a problem hiding this comment.
Could you also remove these commented-out tests? (Sorry for being nitpicky about this, since it’s kind of a minor thing, but it’s easy to fix, so it seems worth doing.)
|
Review app for commit 776dd66 deployed to Heroku: https://hge-ci-pull-2967.herokuapp.com |
|
Review app for commit 0f2837c deployed to Heroku: https://hge-ci-pull-2967.herokuapp.com |
|
Review app for commit 6935fc3 deployed to Heroku: https://hge-ci-pull-2967.herokuapp.com |
|
Review app for commit 85c6ca0 deployed to Heroku: https://hge-ci-pull-2967.herokuapp.com |
|
Review app for commit 08570c8 deployed to Heroku: https://hge-ci-pull-2967.herokuapp.com |
|
Review app https://hge-ci-pull-2967.herokuapp.com is deleted |
Although brotli itself is MIT-licensed, the Haskell brotli library that provides bindings to it is GPL-licensed, so we cannot use it unless we get a response on haskell-hvr/brotli#1.
Description
The brotli lib has licensed under GPL 3.0 only. Hence removing brotli compression until the library author updates the license or an alternates solution found. Gzip compression works as expected.
Affected components
Related Issues
N/A
Solution and Design
brotlifrom library dependenciesSteps to test and verify
Limitations, known bugs & workarounds