server: Don’t allow warnings when building in CI #2892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 6c6e49b |
Contributor
|
Review app for commit 6c6e49b deployed to Heroku: https://hge-ci-pull-2892.herokuapp.com |
ecthiender
reviewed
Sep 17, 2019
|
|
||
| , TableInfo(..) | ||
| , tiName | ||
| , tiDescription |
Contributor
There was a problem hiding this comment.
does this PR require this symbol to be exported?
Contributor
Author
There was a problem hiding this comment.
Yes, the warning in 99174cc is due to it not being exported, which causes an unused identifier warning. (The definition can’t just be deleted because it’s generated by makeLenses, and some of the other lenses are used.)
Contributor
|
Review app https://hge-ci-pull-2892.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, CI does not build the server with the
-WerrorGHC option set, so warnings are not treated as errors. This allowed 99174cc to get merged with an unfixed warning. This PR fixes that.Affected components