这是indexloc提供的服务，不要输入任何密码
Skip to content

check for empty response on migration settings #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2019
Merged

check for empty response on migration settings #2877

merged 1 commit into from
Sep 16, 2019

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Sep 13, 2019

Description

Fixing run_sql result checking while fetching migration setting in cli.

Affected components

  • CLI

Related Issues

#2872
#2862

Solution and Design

Steps to test and verify

  1. Open console using cli
  2. Delete all the rows in hdb_catalog.migration_settings table.
  3. Open the console again using cli and panic shouldn't happen.

Limitations, known bugs & workarounds

@arvi3411301 arvi3411301 added the c/cli Related to CLI label Sep 13, 2019
@netlify
Copy link

netlify bot commented Sep 13, 2019

Deploy preview for hasura-docs ready!

Built with commit 7a3ce82

https://deploy-preview-2877--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 13, 2019

Review app for commit 7a3ce82 deployed to Heroku: https://hge-ci-pull-2877.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2877-7a3ce82c

@arvi3411301 arvi3411301 marked this pull request as ready for review September 13, 2019 12:21
@shahidhk shahidhk changed the title fix cli get setting panic on empty row, close #2872 fix cli get setting panic on empty row (close #2872) Sep 16, 2019
@shahidhk shahidhk changed the title fix cli get setting panic on empty row (close #2872) check for empty response on migration settings (close #2872) Sep 16, 2019
@shahidhk shahidhk changed the title check for empty response on migration settings (close #2872) check for empty response on migration settings (close #2872) (close #2862) Sep 16, 2019
@shahidhk shahidhk changed the title check for empty response on migration settings (close #2872) (close #2862) check for empty response on migration settings Sep 16, 2019
@shahidhk shahidhk merged commit b39d7b9 into hasura:master Sep 16, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 16, 2019

Review app https://hge-ci-pull-2877.herokuapp.com is deleted

@shahidhk shahidhk deleted the issue-2872 branch September 16, 2019 08:50
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@arvi3411301 @polRk
check for empty response on migration settings (hasura#2877)
1940379 
(close hasura#2872) (close hasura#2862)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahidhk shahidhk shahidhk approved these changes

Assignees

@shahidhk shahidhk

Labels

c/cli Related to CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arvi3411301 @hasura-bot @shahidhk