Add "without time zone" types for PGTypes.dateTime (close #2842) #2844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Deploy preview for hasura-docs ready! Built with commit 1c4c390 |
Contributor
|
Review app for commit 1c4c390 deployed to Heroku: https://hge-ci-pull-2844.herokuapp.com |
rikinsk
approved these changes
Sep 6, 2019
Contributor
|
Review app https://hge-ci-pull-2844.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2842
Description
Add "timestamp without time zone" and "time without time zone" to the
PGTypes.dateTimearray.Affected components
Related Issues
#2842
Solution and Design
It seems that
timestamp without time zoneis not recognized as aPGTypes.dateTimeand therefore the PermissionBuilder offered no options for the column.Steps to test and verify
In case the PG version is relevant: server 11.2
timestamp without time zone.If there are any test cases I should add, please let me know and point me to where they're at. Happy to add them, if you'd like.
Limitations, known bugs & workarounds