这是indexloc提供的服务，不要输入任何密码
Skip to content

fix console insert/edit row glitches (close #2840, #2665) #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 9, 2019
Merged

fix console insert/edit row glitches (close #2840, #2665) #2843

merged 10 commits into from
Sep 9, 2019

Conversation

@rikinsk
Copy link
Member

@rikinsk rikinsk commented Sep 6, 2019 •
edited
Loading

Description

  • Handle identity columns in insert / edit row

  • Handle object content columns in edit row

  • Create new tab for edit row

  • Disable Null and Default options in edit row based on column properties

  • italicize views in untracked section (sneaking this in as not worthy of a separate PR)

  • refactor Table header

Affected components

  • Console

Related Issues

#2840, #2665

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@netlify
Copy link

netlify bot commented Sep 6, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 47aaa4b

https://deploy-preview-2843--hasura-docs.netlify.com

@rikinsk rikinsk requested a review from wawhal September 6, 2019 18:25
@rikinsk rikinsk added the c/console Related to console label Sep 6, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 6, 2019

Review app for commit e3c14dd deployed to Heroku: https://hge-ci-pull-2843.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2843-e3c14ddb

@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 6, 2019

Review app for commit 5984713 deployed to Heroku: https://hge-ci-pull-2843.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2843-59847137

wawhal
wawhal suggested changes Sep 7, 2019
View reviewed changes
@rikinsk rikinsk requested a review from wawhal September 9, 2019 10:55
@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 9, 2019

Review app for commit 33031c7 deployed to Heroku: https://hge-ci-pull-2843.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2843-33031c79

wawhal
wawhal previously approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@wawhal wawhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 9, 2019

Review app for commit 6dad910 deployed to Heroku: https://hge-ci-pull-2843.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2843-6dad9106

@rikinsk rikinsk requested a review from wawhal September 9, 2019 13:28
@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 9, 2019

Review app for commit 47aaa4b deployed to Heroku: https://hge-ci-pull-2843.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2843-47aaa4ba

@rikinsk rikinsk merged commit eea1e33 into hasura:master Sep 9, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 9, 2019

Review app https://hge-ci-pull-2843.herokuapp.com is deleted

@rikinsk rikinsk deleted the console-edit-fix branch September 9, 2019 14:07
@rikinsk rikinsk mentioned this pull request Sep 9, 2019
Closed
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@rikinsk @polRk
fix console insert/edit row glitches (close hasura#2840, hasura#2665) (…
0a49c5b 
…hasura#2843)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wawhal wawhal wawhal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rikinsk @hasura-bot @wawhal