fix row comparison operator in event triggers (fix #2036) #2868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 711cf97 |
Contributor
|
Review app for commit 9241785 deployed to Heroku: https://hge-ci-pull-2868.herokuapp.com |
Contributor
|
Review app for commit 711cf97 deployed to Heroku: https://hge-ci-pull-2868.herokuapp.com |
lexi-lambda
approved these changes
Sep 12, 2019
marionschleifer
approved these changes
Sep 12, 2019
Contributor
|
Review app https://hge-ci-pull-2868.herokuapp.com is deleted |
| PERFORM hdb_catalog.insert_event_log(CAST(TG_TABLE_SCHEMA AS text), CAST(TG_TABLE_NAME AS text), CAST('{{NAME}}' AS text), TG_OP, _data); | ||
| END IF; | ||
| BEGIN | ||
| IF (TG_OP <> 'UPDATE') OR (_old <> _new) THEN |
Contributor
There was a problem hiding this comment.
Wouldn't it be more performant if we did a check like the following:
IF (TG_OP <> 'UPDATE') THEN
insert_event_log
ELSE
BEGIN
IF (_old <> new) THEN
insert_event_log
EXCEPTION WHEN undefined_function THEN
IF (_old *<> new) THEN
insert_event_log
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
…ra#2868) Update trigger is failing if any json/geometry columns are present in event payload rows. Use '*<>' operator instead of '<>' to compare the internal binary representation of rows if '<>' doesn’t work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Event triggers are failing if a table contains columns with json/geometry type. It is due to the limitation of the comparison operator (
<>) in the trigger definition.Affected components
Related Issues
fix #2036
Solution and Design
Use composite comparison operator
*<>, which compares the internal binary representation of two rows.Steps to test and verify
Follow the reproduction guide given in issue #2036