这是indexloc提供的服务，不要输入任何密码
Skip to content

display untrackable functions on schema page (close #2249) #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Nov 15, 2019
Merged

display untrackable functions on schema page (close #2249) #2773

merged 40 commits into from
Nov 15, 2019

Conversation

@AnnieAtHasura
Copy link
Contributor

@AnnieAtHasura AnnieAtHasura commented Aug 26, 2019 •
edited by rikinsk
Loading

Description

  • display non trackable functions list on schema page (collapsed by default)

    • show trackable functions requirements msg at start
    • show View btn which redirects to SQL page with fn definition pre-filled

  • display untracked functions section all the time (collapsed by default if no trackable fns)

    • made sense as non trackable fns section wil almost always be shown. might help with feature discoverability as well.
    • show trackable functions requirements msg if no trackable fns found

Affected components

  • Console

Related Issues

#2249

Solution and Design

Steps to test and verify

  • check UI if no untracked fns vs if untracked fns present
  • check View UX for non trackable fns
  • check if the messaging is clear

Limitations, known bugs & workarounds

Anniepoo and others added 19 commits February 21, 2019 10:07
@Anniepoo
added subscriptions-transport-ws to list of dependencies needed for a…
a166f8d 
…pollo
@rikinsk
Merge branch 'master' into master
53dfa72
@rikinsk
Merge branch 'master' into master
47ff219
@Anniepoo
Merge branch 'master' of github.com:hasura/graphql-engine
122eff8
@Anniepoo
Merge branch 'master' of github.com:hasura/graphql-engine
2d72e82
@Anniepoo
Merge branch 'master' of github.com:hasura/graphql-engine
1695e54
@Anniepoo
Merge branch 'master' of github.com:hasura/graphql-engine
5a78ec7
@Anniepoo
Merge branch 'master' of github.com:hasura/graphql-engine
fc7c69c
@Anniepoo
Merge branch 'master' of github.com:hasura/graphql-engine
9f0cf2d
@Anniepoo
Merge branch 'master' of github.com:hasura/graphql-engine
255144c
@Anniepoo
Merge branch 'master' of github.com:hasura/graphql-engine
525ece1
@Anniepoo
Merge branch 'master' of github.com:hasura/graphql-engine
e046aec
@Anniepoo
Merge branch 'master' of github.com:hasura/graphql-engine
015c787
@Anniepoo
Merge branch 'master' of github.com:hasura/graphql-engine
ea2d516
@Anniepoo
Merge branch 'master' of github.com:hasura/graphql-engine
d677710
@Anniepoo
Merge branch 'master' of github.com:hasura/graphql-engine
c155c0e
@Anniepoo
Fixed 2249
352d6bc
@Anniepoo
Merge branch 'master' of github.com:hasura/graphql-engine
a79f49c
@Anniepoo
resolved Schema.js having the untrackablefns stubbed out
a63d949
@netlify
Copy link

netlify bot commented Aug 26, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit a093bcd

https://deploy-preview-2773--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 26, 2019

Review app for commit a63d949 deployed to Heroku: https://hge-ci-pull-2773.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2773-a63d9492

@rikinsk-zz rikinsk-zz added the c/console Related to console label Aug 26, 2019
@CLAassistant
Copy link

CLAassistant commented Sep 17, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 18, 2019

Review app for commit 1b8fcd9 deployed to Heroku: https://hge-ci-pull-2773.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2773-1b8fcd91

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 21, 2019

Review app for commit 2ffbdda deployed to Heroku: https://hge-ci-pull-2773.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2773-2ffbddaf

@rikinsk rikinsk changed the title Display untrackable functions on data page fix #2249 display untrackable functions on schema page (close #2249) Oct 21, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 21, 2019

Review app for commit 1772450 deployed to Heroku: https://hge-ci-pull-2773.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2773-1772450f

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 21, 2019

Review app for commit 6ffd8b4 deployed to Heroku: https://hge-ci-pull-2773.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2773-6ffd8b47

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 21, 2019

Review app for commit 7f75e11 deployed to Heroku: https://hge-ci-pull-2773.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2773-7f75e11b

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 22, 2019

Review app for commit cabf3df deployed to Heroku: https://hge-ci-pull-2773.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2773-cabf3df1

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 22, 2019

Review app for commit d935b6a deployed to Heroku: https://hge-ci-pull-2773.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2773-d935b6aa

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 22, 2019

Review app for commit 19f7beb deployed to Heroku: https://hge-ci-pull-2773.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2773-19f7beb9

@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 23, 2019

Review app for commit a9c3fa7 deployed to Heroku: https://hge-ci-pull-2773.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2773-a9c3fa71

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 14, 2019

Review app for commit 5069e41 deployed to Heroku: https://hge-ci-pull-2773.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2773-5069e41f

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 14, 2019

Review app for commit d7ce95d deployed to Heroku: https://hge-ci-pull-2773.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2773-d7ce95da

@rikinsk rikinsk merged commit dc1748b into hasura:master Nov 15, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 15, 2019

Beep boop! 🤖

GIF

Awesome work @AnnieAtHasura! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 15, 2019

Review app https://hge-ci-pull-2773.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 15, 2019

Review app for commit a093bcd deployed to Heroku: https://hge-ci-pull-2773.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2773-a093bcda

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@AnnieAtHasura @polRk
display untrackable functions on schema page (close hasura#2249) (has…
0aa22a2 
…ura#2773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

Assignees

No one assigned

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AnnieAtHasura @hasura-bot @CLAassistant @rikinsk @rikinsk-zz @Anniepoo