get all Set-Cookie headers (fix # 2688) #2739
Conversation
1b40131 to
cd27157
Compare
|
Deploy preview for hasura-docs ready! Built with commit 1b40131 |
|
Deploy preview for hasura-docs ready! Built with commit 630b24c |
|
Review app for commit cd27157 deployed to Heroku: https://hge-ci-pull-2739.herokuapp.com |
lexi-lambda
left a comment
There was a problem hiding this comment.
Changes LGTM, but is it possible/worth it to add a test case for this?
|
Review app for commit f5b0957 deployed to Heroku: https://hge-ci-pull-2739.herokuapp.com |
|
@lexi-lambda I thought about the test-case, but then got put off because I will have to add a python graphql resolver which returns multiple "Set-Cookie" headers. Just seemed too much work for an obvious fix (I tested manually ofc). But in case you insist, I can do this as well. |
|
If it’s a lot of work, I agree that it probably isn’t worth the effort; just figured I’d ask. I’ll merge this once CI passes. |
|
Review app for commit 630b24c deployed to Heroku: https://hge-ci-pull-2739.herokuapp.com |
|
Review app https://hge-ci-pull-2739.herokuapp.com is deleted |
Description
Read all
Set-Cookieheaders from Remote Schema response and fwd them to the client.Affected components
Related Issues
#2688
Solution and Design
Read all
Set-Cookieheaders.