这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@tirumaraiselvan
Copy link
Contributor

Description

Before:

{
  "errors": [
    {
      "extensions": {
        "path": "$",
        "code": "unexpected"
      },
      "message": "HttpExceptionRequest Request {\n  host                 = \"localhost\"\n  port                 = 4000\n  secure               = False\n  requestHeaders       = [(\"Content-Type\",\"application/json\"),(\"User-Agent\",\"hasura-graphql-engine/remote-schema-logging-b2b33755-dirty\"),(\"SECRET_HEADER\",\"very_secret_hahahha\"),(\"x-hasura-role\",\"user\")]\n  path                 = \"/\"\n  queryString          = \"\"\n  method               = \"POST\"\n  proxy                = Nothing\n  rawBody              = False\n  redirectCount        = 10\n  responseTimeout      = ResponseTimeoutDefault\n  requestVersion       = HTTP/1.1\n}\n (ConnectionFailure Network.Socket.connect: <socket: 35>: does not exist (Connection refused))"
    }
  ]
}

After:

{
  "errors": [
    {
      "extensions": {
        "path": "$",
        "code": "unexpected"
      },
      "message": "ConnectionFailure Network.Socket.connect: <socket: 36>: does not exist (Connection refused)"
    }
  ]
}

Affected components

  • Server

Related Issues

Solution and Design

HTTPException has two parts: Request and ExceptionContent. We now return only the ExceptionContent.

Steps to test and verify

Limitations, known bugs & workarounds

@netlify
Copy link

netlify bot commented Aug 16, 2019

Deploy preview for hasura-docs ready!

Built with commit 262e248

https://deploy-preview-2738--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit 8bc9baf deployed to Heroku: https://hge-ci-pull-2738.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2738-8bc9bafa

Copy link
Contributor

@ecthiender ecthiender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasura-bot
Copy link
Contributor

Review app for commit 262e248 deployed to Heroku: https://hge-ci-pull-2738.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2738-262e2482

@lexi-lambda lexi-lambda merged commit 46f2eca into hasura:master Aug 20, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-2738.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants