fix issue with editing boolean fields (fix #2536) #2765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 78ca9f3 |
Contributor
Author
|
From what I see, the CI pipeline failure caused by some configuration issues and is not related to one line of change in this PR. Is there anything that can do about that? |
|
|
Contributor
|
Review app for commit ec36a91 deployed to Heroku: https://hge-ci-pull-2765.herokuapp.com |
ec36a91 to
ae97c36
Compare
Contributor
|
Review app for commit ae97c36 deployed to Heroku: https://hge-ci-pull-2765.herokuapp.com |
rikinsk
approved these changes
Aug 29, 2019
Contributor
|
Review app https://hge-ci-pull-2765.herokuapp.com is deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clicking on the boolean field value dropdown would open a select box but it got closed automatically, therefore, users were unable to edit boolean fields values.
Affected components
Related Issues
#2536 #2798
Solution and Design
The new code checks the radio button by changing its
checkedproperty instead of simulating a click on it (which would lead to the loss of focus and automatic closure of dropdown).Steps to test and verify
You can follow the exact reproduction steps that have been written in the original issue.
Limitations, known bugs & workarounds