这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented Aug 21, 2019

Description

  • in row permissions, do not switch custom check radio if filter matches another option (ie: same as ..)
  • stop new role input box from clearing if new role matches existing role while typing

Affected components

  • Console

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@netlify
Copy link

netlify bot commented Aug 21, 2019

Deploy preview for hasura-docs ready!

Built with commit 94f411a

https://deploy-preview-2763--hasura-docs.netlify.com

@rikinsk-zz rikinsk-zz added the c/console Related to console label Aug 21, 2019
@rikinsk-zz rikinsk-zz requested a review from wawhal August 21, 2019 12:21
@hasura-bot
Copy link
Contributor

Review app for commit 5822aba deployed to Heroku: https://hge-ci-pull-2763.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2763-5822abab

wawhal
wawhal previously approved these changes Aug 22, 2019
Copy link
Contributor

@wawhal wawhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasura-bot
Copy link
Contributor

Review app for commit 9bef527 deployed to Heroku: https://hge-ci-pull-2763.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2763-9bef5278

@rikinsk-zz rikinsk-zz requested a review from wawhal August 23, 2019 08:13
@hasura-bot
Copy link
Contributor

Review app for commit de03e4a deployed to Heroku: https://hge-ci-pull-2763.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2763-de03e4ac

@rikinsk-zz rikinsk-zz merged commit 4bdf965 into hasura:master Aug 23, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-2763.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the console-permissions branch August 23, 2019 12:34
@hasura-bot
Copy link
Contributor

Review app for commit 94f411a deployed to Heroku: https://hge-ci-pull-2763.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2763-94f411a0

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants