这是indexloc提供的服务，不要输入任何密码
Skip to content

schema permissions summary page on console #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 53 commits into from
Aug 20, 2019
Merged

schema permissions summary page on console #2693

merged 53 commits into from
Aug 20, 2019

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented Aug 8, 2019 •
edited
Loading

Description

This adds a permissions summary page for a PG schema to the console

  • show summary of access control for all roles across tables and actions
  • allow copy of permissions from one role to others

TODO:

  • push permissions state to open appropriate section in permissions page on edit
  • Try out a better layout for displaying the 3-dimensional data (roles x tables x actions)

Misc:

  • update About page container
  • remove inconsistent highlighting of tooltip icons in Add table
  • Permissions page
    • highlight actions and roles as headers in table
    • move bulk action selector to end
    • scroll to edit/bulk section on selection
    • show permission edit icon only on hover
    • pre-select table and action in clone section (resolves Form error handling on clone permissions #2636)
  • Sidebars
    • updated icons for remote schema and events in sidebar
    • update function icon colour in data sidebar to match text
    • update routing in data sidebar to use utils

Affected components

  • Console

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk-zz rikinsk-zz added c/console Related to console s/wip Status: This issue is a work in progress labels Aug 8, 2019
@netlify
Copy link

netlify bot commented Aug 8, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 671b26a

https://deploy-preview-2693--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 8, 2019

Review app for commit a7700cb deployed to Heroku: https://hge-ci-pull-2693.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2693-a7700cb1

@coco98
Copy link
Contributor

coco98 commented Aug 8, 2019

I think if we get a link to the "edit permissions" working, then the rest is just styling right? Seems to work pretty well otherwise :)

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 13, 2019

Review app for commit cdddccf deployed to Heroku: https://hge-ci-pull-2693.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2693-cdddccf2

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 13, 2019

Review app for commit 29138ea deployed to Heroku: https://hge-ci-pull-2693.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2693-29138ea6

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 13, 2019

Review app for commit 8ad628c deployed to Heroku: https://hge-ci-pull-2693.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2693-8ad628c4

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 19, 2019

Review app for commit b6d356c deployed to Heroku: https://hge-ci-pull-2693.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2693-b6d356cf

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 19, 2019

Review app for commit 2affa39 deployed to Heroku: https://hge-ci-pull-2693.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2693-2affa39a

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 19, 2019

Review app for commit 3a64b8d deployed to Heroku: https://hge-ci-pull-2693.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2693-3a64b8d8

@rikinsk-zz rikinsk-zz marked this pull request as ready for review August 20, 2019 10:58
@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 20, 2019

Review app for commit 096cb8c deployed to Heroku: https://hge-ci-pull-2693.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2693-096cb8c1

@rikinsk-zz rikinsk-zz removed the s/wip Status: This issue is a work in progress label Aug 20, 2019
@coco98
Copy link
Contributor

coco98 commented Aug 20, 2019 •
edited
Loading

@rikinsk Does the copy button on the clone modal not work? I was trying it out.

@rikinsk-zz
Copy link
Author

rikinsk-zz commented Aug 20, 2019 •
edited
Loading

@coco98 of course it does! at least it did last time i checked

edit: verified. seems to be working

@rikinsk-zz
Copy link
Author

rikinsk-zz commented Aug 20, 2019

/heroku deploy

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 20, 2019

Review app for commit e7f95b0 deployed to Heroku: https://hge-ci-pull-2693.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2693-e7f95b0f

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 20, 2019

Review app for commit 4860156 deployed to Heroku: https://hge-ci-pull-2693.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2693-48601566

@rikinsk-zz rikinsk-zz requested a review from dsandip August 20, 2019 13:10
dsandip
dsandip previously approved these changes Aug 20, 2019
View reviewed changes
@rikinsk-zz rikinsk-zz requested a review from dsandip August 20, 2019 13:21
@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 20, 2019

Review app for commit 671b26a deployed to Heroku: https://hge-ci-pull-2693.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2693-671b26af

@rikinsk-zz rikinsk-zz merged commit 03ea997 into hasura:master Aug 20, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 20, 2019

Review app https://hge-ci-pull-2693.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the console-roles branch August 20, 2019 13:42
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@rikinsk @polRk
add schema permissions summary page + update table permissions page (h…
df5ded3 
…asura#2693)

Schema permissions summary page

* show summary of access control for all roles across tables and actions
* allow copy of permissions from one role to others

Table permissions page

* highlight actions and roles as headers in table
* move bulk action selector to end of row
* scroll to edit/bulk section when opened
* pre-select table and action in clone section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsandip dsandip dsandip approved these changes

Assignees

No one assigned

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Form error handling on clone permissions

5 participants

@rikinsk-zz @hasura-bot @coco98 @dsandip @rikinsk