这是indexloc提供的服务，不要输入任何密码
Skip to content

Use SIGINT as the stopsignal in the dockerfile #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2019
Merged

Use SIGINT as the stopsignal in the dockerfile #2685

merged 1 commit into from
Aug 11, 2019

Conversation

@lorenzo
Copy link
Contributor

@lorenzo lorenzo commented Aug 7, 2019

Description

Haskell expects the signal to be SIGINT, but the docker default is
SIGTERM.

Correcting this.

Affected components

  • Server
  • Build System

@lorenzo lorenzo requested a review from lexi-lambda as a code owner August 7, 2019 10:23
@CLAassistant
Copy link

CLAassistant commented Aug 7, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Aug 7, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 3ee3495

https://deploy-preview-2685--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 7, 2019

Review app for commit 321da37 deployed to Heroku: https://hge-ci-pull-2685.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2685-321da370

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 8, 2019

Review app for commit f5596cd deployed to Heroku: https://hge-ci-pull-2685.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2685-f5596cdf

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 9, 2019

Review app for commit 31513d6 deployed to Heroku: https://hge-ci-pull-2685.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2685-31513d6c

@0x777
Copy link
Member

0x777 commented Aug 9, 2019 •
edited
Loading

Looks like the last test to finish always fails after this change. A quick glance (could be wrong) tells me that the problem is in stop_services in test-server.sh. Somehow WH_PID and WHC_PID are empty. Given that the tests don't run against a docker instance this is very surprising.

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 9, 2019

Review app for commit 6559a5b deployed to Heroku: https://hge-ci-pull-2685.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2685-6559a5ba

@lorenzo
Copy link
Contributor Author

lorenzo commented Aug 9, 2019

@0x777 seems like all tests are passing now?

@lorenzo @lexi-lambda
Use SIGINT as the stopsignal in the dockerfile
3ee3495 
Haskell expects the signal to be `SIGINT`, but the docker default is
`SIGTERM`.

Correcting this.
@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 11, 2019

Review app for commit 3ee3495 deployed to Heroku: https://hge-ci-pull-2685.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2685-3ee34952

lexi-lambda
lexi-lambda approved these changes Aug 11, 2019
View reviewed changes
Copy link
Contributor

@lexi-lambda lexi-lambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing again, but it doesn’t seem to have anything to do with this change (as it shouldn’t), since they’re failing on other PRs, too. It seems like those tests are flaky, which we should definitely fix, but I see no reason not to merge this PR in the meantime. Thank you for the contribution!

@lexi-lambda lexi-lambda merged commit e952495 into hasura:master Aug 11, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 11, 2019

Review app https://hge-ci-pull-2685.herokuapp.com is deleted

@lexi-lambda lexi-lambda mentioned this pull request Aug 11, 2019
Closed
@lorenzo lorenzo deleted the add-stop-signal branch August 11, 2019 09:04
@marionschleifer marionschleifer added the c/community Related to community content label Aug 12, 2019
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@lorenzo @polRk
Use SIGINT as the stopsignal in the dockerfile (hasura#2685)
69354ab 
Haskell expects the signal to be `SIGINT`, but the docker default is
`SIGTERM`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lexi-lambda lexi-lambda lexi-lambda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/community Related to community content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lorenzo @CLAassistant @hasura-bot @0x777 @lexi-lambda @marionschleifer