这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rikinsk-zz
Copy link

Description

Remove the markdown and html options from text column edit boxes. Eventually we should use a proper rich text editor for this instead of just AceEditor.

Affected components

  • Console

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk-zz rikinsk-zz added the c/console Related to console label Aug 7, 2019
@rikinsk-zz rikinsk-zz requested a review from coco98 August 7, 2019 09:44
@netlify
Copy link

netlify bot commented Aug 7, 2019

Deploy preview for hasura-docs ready!

Built with commit 611a553

https://deploy-preview-2684--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit 4e79d4f deployed to Heroku: https://hge-ci-pull-2684.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2684-4e79d4fd

Copy link
Contributor

@wawhal wawhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@rikinsk-zz rikinsk-zz merged commit 01e71ca into hasura:master Aug 7, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-2684.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the console-edit-text branch August 7, 2019 13:12
@hasura-bot
Copy link
Contributor

Review app for commit 611a553 deployed to Heroku: https://hge-ci-pull-2684.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2684-611a5533

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants