better key persistence in console #2686

wawhal · 2019-08-07T12:34:36Z

Description

in CLI mode show error message on login page if no/invalid admin secret
allow not persisting admin secret in browser local storage on login page
admin secret value in graphiql headers is masked in local storage, its value is set to current admin secret when reading back from local storage
if admin secret is set and graphiql headers does not have the admin secret header set (typically happens when admin secret is just added) add a new admin secret header and set in local storage that this has been done. Now if user removes the admin secret header it will not be added back.
make graphiql introspection query only after headers have been set.
change routes from /metadata -> /settings
add separate logout page

Affected components

Console

Related Issues

#2660, #2663

Solution and Design

Rewrite login page and its associated actions. Add a checkbox to choose whether to persist the admin secret.
- Persist: admin secret set to LS. admin secret is set in globals
- Do not persist: admin secret is set in globals
implement getAdminSecret fn which fetches from localstorage or globals
On GraphiQL page load, dispatch header init:
- read headers from LS. set actual admin secret value if admin secret header present
- if admin secret is set and admin secret header is not present, add admin secret header and persist to LS that admin secret header wasAdded. Do not add admin secret header if admin secret header was already added once. ie. wasAdded value is set in LS.
- persist headers to LS. mask admin secret value if header is present.
- push headers to redux and mark headers are initialised as a flag
Introspection happens only after headers are initialised

Steps to test and verify

Cases:

With vs Without admin secret
Server vs CLI mode
Persisted vs Non-persisted admin secret
Prod vs Dev mode

Test:

Login behaviour
Logout behaviour
Graphiql headers
Data API headers

Limitations, known bugs & workarounds

netlify · 2019-08-07T12:35:43Z

Deploy preview for hasura-docs ready!

Built with commit 05e16df

https://deploy-preview-2686--hasura-docs.netlify.com

hasura-bot · 2019-08-07T12:42:29Z

Review app for commit 540c216 deployed to Heroku: https://hge-ci-pull-2686.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2686-540c2164

tirumaraiselvan · 2019-08-09T11:54:21Z

Also, please make sure that when a role header is set then two queries are NOT made for introspection (first as admin, then as the role).

hasura-bot · 2019-08-09T12:09:37Z

Review app for commit 4e416ce deployed to Heroku: https://hge-ci-pull-2686.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2686-4e416cec

rikinsk-zz

Admin secret is undefined. Something's wrong here

console/src/components/Login/Login.js

console/src/components/Login/Actions.js

console/src/components/Login/Login.js

hasura-bot · 2019-08-21T17:41:28Z

Review app for commit d3a6869 deployed to Heroku: https://hge-ci-pull-2686.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2686-d3a68696

hasura-bot · 2019-08-22T04:50:03Z

Review app for commit 506cc22 deployed to Heroku: https://hge-ci-pull-2686.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2686-506cc229

hasura-bot · 2019-08-22T08:09:44Z

Review app for commit 7312c33 deployed to Heroku: https://hge-ci-pull-2686.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2686-7312c335

hasura-bot · 2019-08-26T11:01:06Z

Review app for commit cc22c8c deployed to Heroku: https://hge-ci-pull-2686.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2686-cc22c8cb

hasura-bot · 2019-08-29T08:05:45Z

Review app for commit 5a01ac5 deployed to Heroku: https://hge-ci-pull-2686.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2686-5a01ac5d

hasura-bot · 2019-09-21T10:00:17Z

Review app for commit b3b6b06 deployed to Heroku: https://hge-ci-pull-2686.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2686-b3b6b06c

rikinsk · 2019-09-25T11:32:48Z

/heroku deploy

hasura-bot · 2019-09-25T11:35:50Z

Review app for commit d0b3fd9 deployed to Heroku: https://hge-ci-pull-2686.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2686-d0b3fd9a

hasura-bot · 2019-09-25T14:50:38Z

Review app for commit 05e16df deployed to Heroku: https://hge-ci-pull-2686.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2686-05e16df9

resolved

hasura-bot · 2019-09-25T15:46:32Z

Review app https://hge-ci-pull-2686.herokuapp.com is deleted

rikinsk · 2019-09-27T11:16:36Z

/heroku deploy

hasura-bot · 2019-09-27T11:17:36Z

Review app for commit 05e16df deployed to Heroku: https://hge-ci-pull-2686.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2686-05e16df9

rikinsk · 2019-09-27T11:30:12Z

/heroku destroy

hasura-bot · 2019-09-27T11:30:14Z

@rikinsk not a valid heroku command (deploy, delete)

rikinsk · 2019-09-27T11:30:26Z

/heroku delete

hasura-bot · 2019-09-27T11:30:27Z

Review app https://hge-ci-pull-2686.herokuapp.com is deleted

* change login flow to handle admin secret persistence * handle headers init state * add tooltip for remember-me * remove log, make label clickable * fix a closure scope bug * handle login verification at route level * update Login.js * refactor * remove extra file * refactor * add id to tooltips * remove adminsecretlabel + update admin secret storage flow * fix heartIcon close handling * . * fix admin secret setting * fix urlPrefix * add admin secret header if not present * update jwt analyzer icon * persist if admin secret header has already been added * set cli console mode as constant * handle CLI admin secret errors * make separate logout page * fix typos * fix typos * fix typos * fix typos * fix cli error * fix login page path

change login flow to handle admin secret persistence

540c216

wawhal requested review from rikinsk-zz August 8, 2019 10:25

wawhal assigned rikinsk-zz Aug 8, 2019

rikinsk-zz added the c/console Related to console label Aug 8, 2019

rikinsk-zz marked this pull request as ready for review August 9, 2019 09:25

Rishichandra Wawhal added 2 commits August 9, 2019 16:48

handle headers init state

3e80d0d

add tooltip for remember-me

4e416ce

wawhal mentioned this pull request Aug 16, 2019

After Hasura login the credentials remain visible? #2660

Closed

rikinsk-zz suggested changes Aug 21, 2019

View reviewed changes

console/src/components/Login/Login.js Outdated Show resolved Hide resolved

console/src/components/Login/Login.js Outdated Show resolved Hide resolved

rikinsk-zz previously requested changes Aug 21, 2019

View reviewed changes

console/src/components/Login/Actions.js Outdated Show resolved Hide resolved

console/src/components/Login/Login.js Outdated Show resolved Hide resolved

remove log, make label clickable

d3a6869

fix a closure scope bug

506cc22

wawhal added the s/do-not-merge Do not merge this pull request to master label Aug 22, 2019

handle login verification at route level

7312c33

rikinsk added 2 commits August 26, 2019 16:21

update Login.js

7fd8eb8

Merge branch 'master' into issue-250-internal

cc22c8c

rikinsk-zz self-requested a review August 26, 2019 10:56

rikinsk added 2 commits August 28, 2019 14:03

Merge branch 'master' into issue-250-internal

cc455d1

refactor

5a01ac5

wawhal requested a review from rikinsk as a code owner August 29, 2019 07:42

add admin secret header if not present

b3b6b06

rikinsk added 3 commits September 23, 2019 14:33

update jwt analyzer icon

890e4da

Merge branch 'master' into issue-250-internal

a70427d

persist if admin secret header has already been added

6806028

rikinsk removed the s/do-not-merge Do not merge this pull request to master label Sep 24, 2019

rikinsk added 9 commits September 25, 2019 14:15

set cli console mode as constant

84ee322

handle CLI admin secret errors

538ed26

make separate logout page

2a462f5

Merge branch 'master' into issue-250-internal

77c0538

fix typos

be88baa

fix typos

94ac7c3

fix typos

fd437bc

fix typos

9a2b64a

fix cli error

d0b3fd9

fix login page path

05e16df

rikinsk approved these changes Sep 25, 2019

View reviewed changes

rikinsk merged commit 1d1de94 into hasura:master Sep 25, 2019

better key persistence in console #2686

better key persistence in console #2686

Uh oh!

Conversation

wawhal commented Aug 7, 2019 • edited by rikinsk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Affected components

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Uh oh!

netlify bot commented Aug 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hasura-bot commented Aug 7, 2019

Uh oh!

tirumaraiselvan commented Aug 9, 2019

Uh oh!

hasura-bot commented Aug 9, 2019

Uh oh!

rikinsk-zz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hasura-bot commented Aug 21, 2019

Uh oh!

hasura-bot commented Aug 22, 2019

Uh oh!

hasura-bot commented Aug 22, 2019

Uh oh!

hasura-bot commented Aug 26, 2019

Uh oh!

hasura-bot commented Aug 29, 2019

Uh oh!

hasura-bot commented Sep 21, 2019

Uh oh!

rikinsk commented Sep 25, 2019

Uh oh!

hasura-bot commented Sep 25, 2019

Uh oh!

hasura-bot commented Sep 25, 2019

Uh oh!

hasura-bot commented Sep 25, 2019

Uh oh!

rikinsk commented Sep 27, 2019

Uh oh!

hasura-bot commented Sep 27, 2019

Uh oh!

rikinsk commented Sep 27, 2019

Uh oh!

hasura-bot commented Sep 27, 2019

Uh oh!

rikinsk commented Sep 27, 2019

Uh oh!

hasura-bot commented Sep 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

wawhal commented Aug 7, 2019 •

edited by rikinsk

Loading

netlify bot commented Aug 7, 2019 •

edited

Loading