capture Postgres error code 22025 as HTTP 400 bad request (close #2486) #2671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit c70d92b |
Contributor
|
Review app for commit f305a93 deployed to Heroku: https://hge-ci-pull-2671.herokuapp.com |
lexi-lambda
previously approved these changes
Aug 8, 2019
f305a93 to
c70d92b
Compare
lexi-lambda
approved these changes
Aug 8, 2019
Contributor
|
Review app for commit c70d92b deployed to Heroku: https://hge-ci-pull-2671.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-2671.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The server used to throw HTTP
500exception for invalid_likepattern. Change it to400 Bad Request.Affected components
Related Issues
fix #2486
Solution and Design
Capture
22025Postgres error code and convert it into400 Bad Request.Steps to test and verify
Follow the reproduction guide in #2486
Limitations, known bugs & workarounds