fix error code for when insertion check constraint fails (fix #257) #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x777
reviewed
Aug 7, 2018
| simplifyError txErr = do | ||
| stmtErr <- Q.getPGStmtErr txErr | ||
| codeMsg <- getPGCodeMsg stmtErr | ||
| extractError codeMsg | ||
| errTxt <- extractError codeMsg |
There was a problem hiding this comment.
Let's change extractError itself to return both code and message. We'll probably need to use the correct codes for the rest of the Postgres errors too
|
Review app available at: https://hge-ci-pull-267.herokuapp.com |
|
Review app available at: https://hge-ci-pull-267.herokuapp.com |
|
Review app available at: https://hge-ci-pull-267.herokuapp.com |
|
Review app available at: https://hge-ci-pull-267.herokuapp.com |
|
Review app available at: https://hge-ci-pull-267.herokuapp.com |
0x777
approved these changes
Aug 10, 2018
|
Review app available at: https://hge-ci-pull-267.herokuapp.com |
|
Review app https://hge-ci-pull-267.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
V3_GIT_ORIGIN_REV_ID: 9eba8544b8401563b27c83f87e35b8448922b2f2
hasura-bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
V3_GIT_ORIGIN_REV_ID: 9eba8544b8401563b27c83f87e35b8448922b2f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.