Set LANG=C.UTF-8 in the docker container (fix #2571) #2647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit ffb81bc |
Contributor
|
Review app for commit a7cf6d4 deployed to Heroku: https://hge-ci-pull-2647.herokuapp.com |
a7cf6d4 to
97397da
Compare
Contributor
|
Review app for commit 97397da deployed to Heroku: https://hge-ci-pull-2647.herokuapp.com |
0x777
approved these changes
Aug 1, 2019
shahidhk
approved these changes
Aug 1, 2019
Contributor
|
Review app for commit ffb81bc deployed to Heroku: https://hge-ci-pull-2647.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-2647.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a quick fix for #2571 that incorporates the changes from hasura/haskell-docker-builder#1 and sets
LANG=C.UTF-8in thehasura/graphql-engineimage. I have some bigger changes on another branch that change the CI around in more drastic ways to try and make it possible to write tests for this kind of thing, but that’s proven to be a lot of work, so this is a simple solution for now.Affected components
Related Issues
#2571, hasura/haskell-docker-builder#1
Steps to test and verify
Since this isn’t under test coverage, it needs to be tested manually: run the image against a database with some Unicode text in it (such as the schema with a comment mentioned in #2571) and make sure hitting the
pg_dumpendpoint works okay.