add flag to disable ci colors (close #2072) #2634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Deploy preview for hasura-docs ready! Built with commit a82b2ae |
Contributor
|
Review app for commit 592593a deployed to Heroku: https://hge-ci-pull-2634.herokuapp.com |
Contributor
|
Review app for commit a82b2ae deployed to Heroku: https://hge-ci-pull-2634.herokuapp.com |
shahidhk
approved these changes
Jul 30, 2019
Contributor
|
Review app https://hge-ci-pull-2634.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
* added log-level flag * fix up the colors * fix description
This was referenced Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
--no-colorflag to address: (fix #2072 )Makes it so that outputs wont get colorized
Affected components
Solution and Design
Used logrus'
DisableColorSteps to test and verify
make build$PATH_TO_OUTPUT/cli-hasura-{{.OS}}-{{.Arch}} versionto produce the colored output$PATH_TO_OUTPUT/cli-hasura-{{.OS}}-{{.Arch}} version --no-colorto produce the non colored output