do not use sub-query for permission limit if aggregations are not present #2630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 36c6cbd |
Contributor
|
Review app for commit d1cf004 deployed to Heroku: https://hge-ci-pull-2630.herokuapp.com |
…g merged with aggregate select one
Contributor
|
Review app for commit 03e0840 deployed to Heroku: https://hge-ci-pull-2630.herokuapp.com |
Contributor
|
Review app for commit 7a8b8e8 deployed to Heroku: https://hge-ci-pull-2630.herokuapp.com |
lexi-lambda
approved these changes
Jul 31, 2019
Contributor
|
Review app for commit 36c6cbd deployed to Heroku: https://hge-ci-pull-2630.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-2630.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change related to permission limits in #2027 has slow down the queries. This PR fixes that.
Affected components
Related Issues
N/A
Solution and Design
The presence of aggregations in queries affects the usage of a subquery in selecting JSON rows. If aggregations present, then use subquery for permission limit.
The application of limit in
BaseNodedepends on whether a subquery is being used.Refer
Files changedfor in-depth details.To Reviewer
Only
src-lib/Hasura/RQL/DML/Select/Internal.hsmodule is changed and a utility type is added insrc-lib/Hasura/RQL/DML/Select/Types.hsSteps to test and verify
Define permission to a table with a limit. Make a
<table-name>_aggregatequery with and withoutaggregatefield. Look for the generated SQL statement using theAnalyzebutton on the console.Limitations, known bugs & workarounds