这是indexloc提供的服务，不要输入任何密码
Skip to content

update styles for tables in console #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Aug 9, 2019
Merged

update styles for tables in console #2629

merged 25 commits into from
Aug 9, 2019

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented Jul 29, 2019 •
edited
Loading

Description

Update styles of data tables in console (Browse rows + RawSQL) for better readability

  • add striping
  • reduce vertical padding
  • column widths based on content
  • table width based on content
  • handle display of data represented as objects (e.g. jsonb, geaography)
  • display data with correct formatting in row expanded mode
  • show pagination section even if numRows < page size
  • hide filter/sort/pagination sections for object relationship

Affected components

  • Console

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk-zz rikinsk-zz added c/console Related to console s/wip Status: This issue is a work in progress labels Jul 29, 2019
@netlify
Copy link

netlify bot commented Jul 29, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 727d5d9

https://deploy-preview-2629--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 29, 2019

Review app for commit 15894ff deployed to Heroku: https://hge-ci-pull-2629.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2629-15894ffe

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 30, 2019

Review app for commit b9c88fb deployed to Heroku: https://hge-ci-pull-2629.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2629-b9c88fb4

@rikinsk-zz rikinsk-zz changed the title update styling for tables in console update styles for tables in console Jul 31, 2019
@rikinsk-zz rikinsk-zz removed the s/wip Status: This issue is a work in progress label Jul 31, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 31, 2019

Review app for commit 46b0119 deployed to Heroku: https://hge-ci-pull-2629.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2629-46b0119c

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 31, 2019

Review app for commit 3e483b5 deployed to Heroku: https://hge-ci-pull-2629.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2629-3e483b55

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 31, 2019

Review app for commit 6766fe8 deployed to Heroku: https://hge-ci-pull-2629.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2629-6766fe81

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 31, 2019

Review app for commit ea50488 deployed to Heroku: https://hge-ci-pull-2629.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2629-ea504888

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 31, 2019

Review app for commit 7ac7f34 deployed to Heroku: https://hge-ci-pull-2629.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2629-7ac7f34c

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 31, 2019

Review app for commit 99f1dd1 deployed to Heroku: https://hge-ci-pull-2629.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2629-99f1dd14

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 31, 2019

Review app for commit 0d6ce56 deployed to Heroku: https://hge-ci-pull-2629.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2629-0d6ce569

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 31, 2019

Review app for commit ea878ea deployed to Heroku: https://hge-ci-pull-2629.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2629-ea878ea2

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 31, 2019

Review app for commit 0dbd0a1 deployed to Heroku: https://hge-ci-pull-2629.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2629-0dbd0a15

@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 2, 2019

Review app for commit 34468d0 deployed to Heroku: https://hge-ci-pull-2629.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2629-34468d0e

@rikinsk-zz rikinsk-zz mentioned this pull request Aug 2, 2019
Closed
@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 2, 2019

Review app for commit 5718dac deployed to Heroku: https://hge-ci-pull-2629.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2629-5718dac9

@rikinsk-zz rikinsk-zz requested review from coco98 and wawhal August 7, 2019 05:42
@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 7, 2019

Review app for commit f47271f deployed to Heroku: https://hge-ci-pull-2629.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2629-f47271ff

@rikinsk-zz rikinsk-zz merged commit 18822de into hasura:master Aug 9, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Aug 9, 2019

Review app https://hge-ci-pull-2629.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the console-table branch August 9, 2019 10:57
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@rikinsk @polRk
update styles of data tables in console for better readability (hasur…
5d4bcdc 
…a#2629)

* add row striping
* reduce row vertical padding
* column widths based on content
* table width based on content
* handle display of data represented as objects (e.g. jsonb, geaography)
* display data with correct formatting in row expanded mode
* show pagination section even if numRows < page size
* hide filter/sort/pagination sections for object relationship
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coco98 coco98 coco98 approved these changes

@wawhal wawhal Awaiting requested review from wawhal

Assignees

@coco98 coco98

@wawhal wawhal

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rikinsk-zz @hasura-bot @coco98 @wawhal @rikinsk