这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@0x777
Copy link
Member

@0x777 0x777 commented Jul 11, 2019

graphql-engine now uses all the available cores on the machine (previously it had to be explicitly configured by setting GHCRTS env variable to -N). This behaviour can be changed by setting GHCRTS to -N<n> to restrict graphql-engine to n cores. For example, setting GHCRTS to -N1 restricts graphql-engine to one core which was the behaviour till beta.2.

Description

Affected components

  • Server

Related Issues

#2316

Solution and Design

Uses -with-rtsopts to set -N as the RTS option at compile time.

sets -N rts flag by default. Can be disabled by
setting the `GHCRTS` env variable to `-N1`.
@0x777 0x777 requested a review from ecthiender July 11, 2019 10:49
@netlify
Copy link

netlify bot commented Jul 11, 2019

Deploy preview for hasura-docs ready!

Built with commit 0e92d63

https://deploy-preview-2511--hasura-docs.netlify.com

@tirumaraiselvan tirumaraiselvan changed the title use all avaialble cores by default use all available cores by default Jul 11, 2019
shahidhk
shahidhk previously approved these changes Jul 11, 2019
ecthiender
ecthiender previously approved these changes Jul 11, 2019
Copy link
Contributor

@ecthiender ecthiender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasura-bot
Copy link
Contributor

Review app for commit 873be1b deployed to Heroku: https://hge-ci-pull-2511.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2511-873be1b8

@hasura-bot
Copy link
Contributor

Review app for commit 26fb78b deployed to Heroku: https://hge-ci-pull-2511.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2511-26fb78b5

@0x777 0x777 dismissed stale reviews from ecthiender and shahidhk via 1c3469c July 11, 2019 12:07
@hasura-bot
Copy link
Contributor

Review app for commit 1c3469c deployed to Heroku: https://hge-ci-pull-2511.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2511-1c3469c0

@hasura-bot
Copy link
Contributor

Review app for commit 63aee87 deployed to Heroku: https://hge-ci-pull-2511.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2511-63aee872

@ecthiender ecthiender added the c/server Related to server label Jul 11, 2019
@shahidhk shahidhk changed the title use all available cores by default use all available cpu cores by default Jul 11, 2019
@hasura-bot
Copy link
Contributor

Review app for commit 0e92d63 deployed to Heroku: https://hge-ci-pull-2511.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2511-0e92d63b

Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk merged commit 66a2f33 into hasura:master Jul 12, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-2511.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
Use all available cores by default. sets -N rts flag by default. Can be disabled by
setting the `GHCRTS` env variable to `-N1`.
hasura-bot pushed a commit that referenced this pull request Oct 14, 2021
This is the next part in the series of MySQL PRs.

**Purpose**: Adds the Plan module for the data loader.

**Preceding PR:** #2511

**Next PR:** #2549

After #2511 is merged, this can be repointed to `main`. For now it's aimed at #2511, because then the diff display is simpler.

The `undefined` stubs in this PR have code already written, so they won't introduce a maintenance problem. They're only omitted for digestibility of the PR.

PR-URL: hasura/graphql-engine-mono#2529
Co-authored-by: Abby Sassel <3883855+sassela@users.noreply.github.com>
GitOrigin-RevId: 691b35b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/server Related to server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants