这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@thangngoc89
Copy link
Contributor

Fixes #2506

Description

I don't think this PR would have any bad effects on users

Affected components

  • Console

Related Issues

Closes #2506

Solution and Design

It's a simple Javascript type error.

Steps to test and verify

Can't reproduce what's described in #2506 after applying this patch.

Limitations, known bugs & workarounds

Nope.

@thangngoc89 thangngoc89 requested a review from rikinsk-zz as a code owner July 11, 2019 05:17
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @thangngoc89, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2019

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Jul 11, 2019

Deploy preview for hasura-docs ready!

Built with commit 0dd9c07

https://deploy-preview-2507--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit b5396da deployed to Heroku: https://hge-ci-pull-2507.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2507-b5396da7

@shahidhk
Copy link
Member

Thanks for this fix @thangngoc89. Can you sign the CLA so that we can get this merged quickly?

@thangngoc89
Copy link
Contributor Author

@shahidhk I tried but the thing you use for signing CLA is extremely flanky. I'm stucked at this screen (noticed I login already)

image

@rikinsk-zz rikinsk-zz merged commit 2259d77 into hasura:master Jul 11, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-2507.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

GIF

Awesome work @thangngoc89! All of us at Hasura ❤️ what you did.

Thanks again 🤗

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Console] Runtime error on Permission tabs

6 participants