-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Console: Fix type error permission.columns is undefined #2507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Beep boop! 🤖 Hey @thangngoc89, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. 🕐 Stay awesome! 😎 |
|
Deploy preview for hasura-docs ready! Built with commit 0dd9c07 |
|
Review app for commit b5396da deployed to Heroku: https://hge-ci-pull-2507.herokuapp.com |
|
Thanks for this fix @thangngoc89. Can you sign the CLA so that we can get this merged quickly? |
|
@shahidhk I tried but the thing you use for signing CLA is extremely flanky. I'm stucked at this screen (noticed I login already) |
|
Review app https://hge-ci-pull-2507.herokuapp.com is deleted |
|
Beep boop! 🤖 Awesome work @thangngoc89! All of us at Hasura ❤️ what you did. Thanks again 🤗 |
Fixes #2506
Description
I don't think this PR would have any bad effects on users
Affected components
Related Issues
Closes #2506
Solution and Design
It's a simple Javascript type error.
Steps to test and verify
Can't reproduce what's described in #2506 after applying this patch.
Limitations, known bugs & workarounds
Nope.