fix sql to return empty array when there are no columns in a table, close #2481 #2484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit ae1626b |
Member
Author
|
@rikinsk can you check the browse and modify page? |
Contributor
|
Review app for commit f4c3d89 deployed to Heroku: https://hge-ci-pull-2484.herokuapp.com |
rikinsk-zz
approved these changes
Jul 8, 2019
Contributor
|
Review app https://hge-ci-pull-2484.herokuapp.com is deleted |
Contributor
|
Review app for commit ae1626b deployed to Heroku: https://hge-ci-pull-2484.herokuapp.com |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When table has no columns, console gets the list of columns as [null] which breaks parsing. The columns should be []
Affected components
Related Issues
#2481
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds