Support Node v12.x and fix tests on macOS #2455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids sass/node-sass#2632, which causes compilation failures on Node v12.x.
|
|
|
Deploy preview for hasura-docs ready! Built with commit 8342bb8 |
Contributor
|
Review app for commit 269888d deployed to Heroku: https://hge-ci-pull-2455.herokuapp.com |
The shell version caused problems on non-Linux systems since it relied on the non-POSIX -i option for sed, which works slightly differently on BSD and macOS.
0x777
approved these changes
Jul 3, 2019
Contributor
|
Beep boop! 🤖 Awesome work @lexi-lambda! All of us at Hasura ❤️ what you did. Thanks again 🤗 |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
* Bump node-sass to version ^4.12.0 This avoids sass/node-sass#2632, which causes compilation failures on Node v12.x. * Do most of the work in /pg_dump in Haskell instead of shell The shell version caused problems on non-Linux systems since it relied on the non-POSIX -i option for sed, which works slightly differently on BSD and macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes two small portability changes:
It bumps the
node-sassversion to ^4.12.0 to avoid support for node.js 12.x sass/node-sass#2632, which causes installation failures on Node v12.x.It moves the functionality of the
/v1alpha/pg_dumpserver endpoint out of shell code and into Haskell, which avoids a portability problem involving GNU versus BSDsed.Together, these changes were enough to get all the server tests to pass on my machine running macOS 10.14.5.
Affected components
Related Issues
pgConnStringfunction exported by those changes.