improve code for release channel detection #2456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Beep boop! 🤖 Hey @ajeetdsouza, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. 🕐 Stay awesome! 😎 |
|
Deploy preview for hasura-docs ready! Built with commit bd574dd |
Contributor
|
Review app for commit 6bc4edd deployed to Heroku: https://hge-ci-pull-2456.herokuapp.com |
shahidhk
requested changes
Jul 2, 2019
Contributor
|
Review app for commit bd574dd deployed to Heroku: https://hge-ci-pull-2456.herokuapp.com |
0x777
approved these changes
Jul 4, 2019
Contributor
|
Review app https://hge-ci-pull-2456.herokuapp.com is deleted |
Contributor
|
Beep boop! 🤖 Awesome work @ajeetdsouza! All of us at Hasura ❤️ what you did. Thanks again 🤗 |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve efficiency of release channel detection code.
Affected components
Solution and Design
The earlier design would unpack the
Textinto a[Char]and pattern match to check the starting letters of the word. I have changed this to use the inbuiltData.Text.isPrefixOffunction.To the Reviewer (server)
Critical files:
/src-lib/Hasura/Server/Version.hs