这是indexloc提供的服务，不要输入任何密码
Skip to content

make ux for destructive actions consistent #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Sep 10, 2019
Merged

make ux for destructive actions consistent #2400

merged 41 commits into from
Sep 10, 2019

Conversation

@strongSoda
Copy link
Contributor

@strongSoda strongSoda commented Jun 19, 2019 •
edited by rikinsk
Loading

  • add a common getConfirmation fn
  • certain actions will need a harder confirmation (type out some text)

Affected components

  • Console

Related Issues

#1469

@strongSoda strongSoda added k/enhancement New feature or improve an existing feature c/console Related to console labels Jun 19, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 19, 2019

Beep boop! 🤖

Hey @strongSoda, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@netlify
Copy link

netlify bot commented Jun 19, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit c09599b

https://deploy-preview-2400--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 19, 2019

Review app for commit d3cf1b8 deployed to Heroku: https://hge-ci-pull-2400.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2400-d3cf1b88

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 19, 2019

Review app for commit bddc04e deployed to Heroku: https://hge-ci-pull-2400.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2400-bddc04e4

@strongSoda strongSoda added the s/wip Status: This issue is a work in progress label Jun 21, 2019
@strongSoda
Copy link
Contributor Author

strongSoda commented Jun 26, 2019

@rikinsk with modal passing a flag for whether or not to type doesn't make sense cause delete handlers need to be made for it. It's good without the modal. No handlers needed. Just pass true if you need to type else it will show only confirm box.

@strongSoda
Copy link
Contributor Author

strongSoda commented Jun 26, 2019

Now only the table name needs to be entered on table delete. Rest have confirm boxes. But if in future they need input just pass a boolean and tweak the confirm message & it will work. No boolean defaults to confirm box. Boolean of true renders prompt. @rikinsk

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 26, 2019

Review app for commit f9d46c1 deployed to Heroku: https://hge-ci-pull-2400.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2400-f9d46c1e

@rikinsk-zz rikinsk-zz self-assigned this Jun 27, 2019
@rikinsk-zz rikinsk-zz added the e/quickfix can be wrapped up in few hours label Jun 27, 2019
@strongSoda strongSoda requested a review from rikinsk as a code owner September 2, 2019 11:06
rikinsk
rikinsk previously approved these changes Sep 9, 2019
View reviewed changes
@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 9, 2019

Review app for commit 27631c8 deployed to Heroku: https://hge-ci-pull-2400.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2400-27631c88

@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 10, 2019

Review app for commit 48bde2e deployed to Heroku: https://hge-ci-pull-2400.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2400-48bde2ef

@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 10, 2019

Review app for commit da53c09 deployed to Heroku: https://hge-ci-pull-2400.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2400-da53c094

@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 10, 2019

Review app for commit 5f560cd deployed to Heroku: https://hge-ci-pull-2400.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2400-5f560cd0

@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 10, 2019

Review app for commit bdaa4c7 deployed to Heroku: https://hge-ci-pull-2400.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2400-bdaa4c73

@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 10, 2019

Review app for commit 1d48ac9 deployed to Heroku: https://hge-ci-pull-2400.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2400-1d48ac92

@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 10, 2019

Review app for commit d98c43c deployed to Heroku: https://hge-ci-pull-2400.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2400-d98c43cd

@rikinsk rikinsk merged commit 1487cc1 into hasura:master Sep 10, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 10, 2019

Review app https://hge-ci-pull-2400.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 10, 2019

Review app for commit c09599b deployed to Heroku: https://hge-ci-pull-2400.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2400-c09599bf

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@strongSoda @polRk
make destructive actions on console require typed out confirmation (c…
3a2e128 
…lose hasura#1469) (hasura#2400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

Assignees

@rikinsk rikinsk

Labels

c/console Related to console e/intermediate can be wrapped up in a week k/enhancement New feature or improve an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@strongSoda @hasura-bot @rikinsk @rikinsk-zz @shahidhk