这是indexloc提供的服务，不要输入任何密码
Skip to content

show warning for identifiers which do not conform to GraphQL name scheme, close #212 #2422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 24, 2019
Merged

show warning for identifiers which do not conform to GraphQL name scheme, close #212 #2422

merged 9 commits into from
Jul 24, 2019

Conversation

@arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Jun 24, 2019

Description

Show warnings for table, column and relationship names which are not conform to GraphQL naming scheme.

Affected components

  • Console

Related Issues

#212

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@arvi3411301 arvi3411301 requested a review from rikinsk-zz as a code owner June 24, 2019 11:05
@arvi3411301 arvi3411301 added c/console Related to console s/do-not-merge Do not merge this pull request to master s/wip Status: This issue is a work in progress labels Jun 24, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 24, 2019

Review app for commit 8f24a8e deployed to Heroku: https://hge-ci-pull-2422.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2422-8f24a8ec

@netlify
Copy link

netlify bot commented Jun 25, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 125cb41

https://deploy-preview-2422--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 25, 2019

Review app for commit 3a81a18 deployed to Heroku: https://hge-ci-pull-2422.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2422-3a81a18b

@rikinsk-zz rikinsk-zz self-assigned this Jun 27, 2019
@rikinsk-zz rikinsk-zz added e/easy can be wrapped up in a couple of days and removed s/wip Status: This issue is a work in progress labels Jun 27, 2019
rikinsk-zz
rikinsk-zz suggested changes Jul 4, 2019
View reviewed changes
Copy link

@rikinsk-zz rikinsk-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic also has to be added for columns of tables

@rikinsk-zz rikinsk-zz assigned arvi3411301 and unassigned rikinsk-zz Jul 4, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 8, 2019

Review app for commit b8f4923 deployed to Heroku: https://hge-ci-pull-2422.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2422-b8f4923c

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 24, 2019

Review app for commit aafaffd deployed to Heroku: https://hge-ci-pull-2422.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2422-aafaffd8

@rikinsk-zz rikinsk-zz self-requested a review July 24, 2019 13:24
@rikinsk-zz rikinsk-zz removed the s/do-not-merge Do not merge this pull request to master label Jul 24, 2019
rikinsk-zz
rikinsk-zz previously approved these changes Jul 24, 2019
View reviewed changes
@rikinsk-zz rikinsk-zz added the s/ok-to-merge Status: This pull request can be merged to master label Jul 24, 2019
@rikinsk-zz rikinsk-zz merged commit 4405bac into hasura:master Jul 24, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 24, 2019

Review app https://hge-ci-pull-2422.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@arvi3411301 @polRk
show warning for tables, columns, relationships which do not conform …
44eca37 
…to GraphQL naming scheme (close hasura#212) (hasura#2422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rikinsk-zz rikinsk-zz rikinsk-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rikinsk-zz rikinsk-zz

@arvi3411301 arvi3411301

Labels

c/console Related to console e/easy can be wrapped up in a couple of days s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arvi3411301 @hasura-bot @rikinsk-zz @wawhal @rikinsk