这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Jun 18, 2019

Description

add videos to react native tutorial and make minor fixes

Affected components

  • Community Content

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@wawhal wawhal requested a review from shahidhk as a code owner June 18, 2019 11:59
@netlify
Copy link

netlify bot commented Jun 18, 2019

Deploy preview for hasura-docs ready!

Built with commit 5ffc465

https://deploy-preview-2390--hasura-docs.netlify.com

@strongSoda strongSoda added the c/community Related to community content label Jun 19, 2019
@wawhal wawhal requested a review from vnovick June 26, 2019 06:15
@wawhal wawhal added the s/ok-to-merge Status: This pull request can be merged to master label Jun 26, 2019
@shahidhk shahidhk changed the title update react native tutorial with videos learn: update react native tutorial with videos Jun 26, 2019
@shahidhk shahidhk merged commit b52ed4c into hasura:master Jun 26, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-2390.herokuapp.com is deleted

wawhal added a commit to wawhal/graphql-engine that referenced this pull request Jul 3, 2019
* render 404 for nonexistent resources (hasura#2341)

* update console dev logging + add logging disable instructions to README (hasura#2388)

* update table rename handling (hasura#2393)

* suggest column default values (hasura#2352)

* fix postgres query to fetch pg_types default functions (close hasura#2399) (hasura#2402)

* add graphql-voyager to console (close hasura#314) (hasura#2369)

* clear header state for remote-schema (close hasura#2396) (hasura#2401)

* change browse rows action buttons heading id (close hasura#2403) (hasura#2413)

* created docker compose for build and launch of tutorial (hasura#2406)

* fix renaming of columns used in insert permission (fix hasura#2398) (hasura#2414)

* graphql2chartjs: fix mapping of non-array types (hasura#2307)

* add name of ci environment to telemetry data (hasura#2382)

* learn: update react native tutorial with videos (hasura#2390)

* create down migration when a column is dropped (close hasura#2291) (hasura#2385)

* add new column row during add table only after completed prev column def (hasura#2428)

* add a make rule to build server docker image locally (hasura#2410)

* learn: fix twitter share image on homepage (hasura#2437)

* add note on exporting multiple schemas as migration (hasura#2436)

* fix browse rows query error handling + boolean filter value (close hasura#2421) (hasura#2440)

* graphql2chartjs: bump version to 0.3.0 (hasura#2445)

* fix to show error notification when run sql fails in cli mode (close hasura#2438) (hasura#2446)

* freeze requirements.txt for server tests (hasura#2450)

* update postgres permission documentation (fix hasura#2404) (hasura#2405)

* refactor AddTable validation on console (close hasura#1712) (hasura#2408)

* change default type placeholder from 'text' to type (fix 2394) (hasura#2458)

* add server version to console html (close hasura#2444) (hasura#2452)

* fix type placeholders in console insert/edit row (hasura#2460)

* fix relationship page error if array fk relationship exists with table in another schema (hasura#2459)

* infer relationship type using uniqueness constraint of foreign key (close hasura#969) (hasura#2347)

* use server version from console html (hasura#2464)

* add schema explorer ui

* wire up create API, WIP

* ui fixes

* integrate with proxy API

* fetch remote relationships in loadSchema

* fixes

* finish up UI for remote rels; waiting on edit API

* break relationships ui into sections

* move graphql schema to local state

* update relationship label

* restructure

* update styles; add tooltips

* filter out fields (scalar type || wrapped scalar type) and do accept any args

* remove an unnecessary log

* version check init

* add version check for remote relationship on loadSchema

* use FT_REMOTE_RELATIONSHIPS

* allow adding string values for scalar args

* comment code

* add update relationship feature

* cover edge cases for update remote rel

* fix semver issue where sometimes the query would never be called

* remove unnecessary fields from schema tree

* stable

* wip

* wip

* wip

* add version checks

* invalidate remote schema cache appropriately

* Remove unnecessary logs
wawhal added a commit to wawhal/graphql-engine that referenced this pull request Jul 4, 2019
* render 404 for nonexistent resources (hasura#2341)

* update console dev logging + add logging disable instructions to README (hasura#2388)

* update table rename handling (hasura#2393)

* suggest column default values (hasura#2352)

* fix postgres query to fetch pg_types default functions (close hasura#2399) (hasura#2402)

* add graphql-voyager to console (close hasura#314) (hasura#2369)

* clear header state for remote-schema (close hasura#2396) (hasura#2401)

* change browse rows action buttons heading id (close hasura#2403) (hasura#2413)

* created docker compose for build and launch of tutorial (hasura#2406)

* fix renaming of columns used in insert permission (fix hasura#2398) (hasura#2414)

* graphql2chartjs: fix mapping of non-array types (hasura#2307)

* add name of ci environment to telemetry data (hasura#2382)

* learn: update react native tutorial with videos (hasura#2390)

* create down migration when a column is dropped (close hasura#2291) (hasura#2385)

* add new column row during add table only after completed prev column def (hasura#2428)

* add a make rule to build server docker image locally (hasura#2410)

* learn: fix twitter share image on homepage (hasura#2437)

* add note on exporting multiple schemas as migration (hasura#2436)

* fix browse rows query error handling + boolean filter value (close hasura#2421) (hasura#2440)

* graphql2chartjs: bump version to 0.3.0 (hasura#2445)

* fix to show error notification when run sql fails in cli mode (close hasura#2438) (hasura#2446)

* freeze requirements.txt for server tests (hasura#2450)

* update postgres permission documentation (fix hasura#2404) (hasura#2405)

* refactor AddTable validation on console (close hasura#1712) (hasura#2408)

* change default type placeholder from 'text' to type (fix 2394) (hasura#2458)

* add server version to console html (close hasura#2444) (hasura#2452)

* fix type placeholders in console insert/edit row (hasura#2460)

* fix relationship page error if array fk relationship exists with table in another schema (hasura#2459)

* infer relationship type using uniqueness constraint of foreign key (close hasura#969) (hasura#2347)

* use server version from console html (hasura#2464)

* add schema explorer ui

* wire up create API, WIP

* ui fixes

* integrate with proxy API

* fetch remote relationships in loadSchema

* fixes

* finish up UI for remote rels; waiting on edit API

* break relationships ui into sections

* move graphql schema to local state

* update relationship label

* restructure

* update styles; add tooltips

* filter out fields (scalar type || wrapped scalar type) and do accept any args

* remove an unnecessary log

* version check init

* add version check for remote relationship on loadSchema

* use FT_REMOTE_RELATIONSHIPS

* allow adding string values for scalar args

* comment code

* add update relationship feature

* cover edge cases for update remote rel

* fix semver issue where sometimes the query would never be called

* remove unnecessary fields from schema tree

* stable

* wip

* wip

* wip

* add version checks

* invalidate remote schema cache appropriately

* Remove unnecessary logs
wawhal added a commit to wawhal/graphql-engine that referenced this pull request Jul 8, 2019
* render 404 for nonexistent resources (hasura#2341)

* update console dev logging + add logging disable instructions to README (hasura#2388)

* update table rename handling (hasura#2393)

* suggest column default values (hasura#2352)

* fix postgres query to fetch pg_types default functions (close hasura#2399) (hasura#2402)

* add graphql-voyager to console (close hasura#314) (hasura#2369)

* clear header state for remote-schema (close hasura#2396) (hasura#2401)

* change browse rows action buttons heading id (close hasura#2403) (hasura#2413)

* created docker compose for build and launch of tutorial (hasura#2406)

* fix renaming of columns used in insert permission (fix hasura#2398) (hasura#2414)

* graphql2chartjs: fix mapping of non-array types (hasura#2307)

* add name of ci environment to telemetry data (hasura#2382)

* learn: update react native tutorial with videos (hasura#2390)

* create down migration when a column is dropped (close hasura#2291) (hasura#2385)

* add new column row during add table only after completed prev column def (hasura#2428)

* add a make rule to build server docker image locally (hasura#2410)

* learn: fix twitter share image on homepage (hasura#2437)

* add note on exporting multiple schemas as migration (hasura#2436)

* fix browse rows query error handling + boolean filter value (close hasura#2421) (hasura#2440)

* graphql2chartjs: bump version to 0.3.0 (hasura#2445)

* fix to show error notification when run sql fails in cli mode (close hasura#2438) (hasura#2446)

* freeze requirements.txt for server tests (hasura#2450)

* update postgres permission documentation (fix hasura#2404) (hasura#2405)

* refactor AddTable validation on console (close hasura#1712) (hasura#2408)

* change default type placeholder from 'text' to type (fix 2394) (hasura#2458)

* add server version to console html (close hasura#2444) (hasura#2452)

* fix type placeholders in console insert/edit row (hasura#2460)

* fix relationship page error if array fk relationship exists with table in another schema (hasura#2459)

* infer relationship type using uniqueness constraint of foreign key (close hasura#969) (hasura#2347)

* use server version from console html (hasura#2464)

* add schema explorer ui

* wire up create API, WIP

* ui fixes

* integrate with proxy API

* fetch remote relationships in loadSchema

* fixes

* finish up UI for remote rels; waiting on edit API

* break relationships ui into sections

* move graphql schema to local state

* update relationship label

* restructure

* update styles; add tooltips

* filter out fields (scalar type || wrapped scalar type) and do accept any args

* remove an unnecessary log

* version check init

* add version check for remote relationship on loadSchema

* use FT_REMOTE_RELATIONSHIPS

* allow adding string values for scalar args

* comment code

* add update relationship feature

* cover edge cases for update remote rel

* fix semver issue where sometimes the query would never be called

* remove unnecessary fields from schema tree

* stable

* wip

* wip

* wip

* add version checks

* invalidate remote schema cache appropriately

* Remove unnecessary logs
wawhal added a commit to wawhal/graphql-engine that referenced this pull request Jul 12, 2019
* render 404 for nonexistent resources (hasura#2341)

* update console dev logging + add logging disable instructions to README (hasura#2388)

* update table rename handling (hasura#2393)

* suggest column default values (hasura#2352)

* fix postgres query to fetch pg_types default functions (close hasura#2399) (hasura#2402)

* add graphql-voyager to console (close hasura#314) (hasura#2369)

* clear header state for remote-schema (close hasura#2396) (hasura#2401)

* change browse rows action buttons heading id (close hasura#2403) (hasura#2413)

* created docker compose for build and launch of tutorial (hasura#2406)

* fix renaming of columns used in insert permission (fix hasura#2398) (hasura#2414)

* graphql2chartjs: fix mapping of non-array types (hasura#2307)

* add name of ci environment to telemetry data (hasura#2382)

* learn: update react native tutorial with videos (hasura#2390)

* create down migration when a column is dropped (close hasura#2291) (hasura#2385)

* add new column row during add table only after completed prev column def (hasura#2428)

* add a make rule to build server docker image locally (hasura#2410)

* learn: fix twitter share image on homepage (hasura#2437)

* add note on exporting multiple schemas as migration (hasura#2436)

* fix browse rows query error handling + boolean filter value (close hasura#2421) (hasura#2440)

* graphql2chartjs: bump version to 0.3.0 (hasura#2445)

* fix to show error notification when run sql fails in cli mode (close hasura#2438) (hasura#2446)

* freeze requirements.txt for server tests (hasura#2450)

* update postgres permission documentation (fix hasura#2404) (hasura#2405)

* refactor AddTable validation on console (close hasura#1712) (hasura#2408)

* change default type placeholder from 'text' to type (fix 2394) (hasura#2458)

* add server version to console html (close hasura#2444) (hasura#2452)

* fix type placeholders in console insert/edit row (hasura#2460)

* fix relationship page error if array fk relationship exists with table in another schema (hasura#2459)

* infer relationship type using uniqueness constraint of foreign key (close hasura#969) (hasura#2347)

* use server version from console html (hasura#2464)

* add schema explorer ui

* wire up create API, WIP

* ui fixes

* integrate with proxy API

* fetch remote relationships in loadSchema

* fixes

* finish up UI for remote rels; waiting on edit API

* break relationships ui into sections

* move graphql schema to local state

* update relationship label

* restructure

* update styles; add tooltips

* filter out fields (scalar type || wrapped scalar type) and do accept any args

* remove an unnecessary log

* version check init

* add version check for remote relationship on loadSchema

* use FT_REMOTE_RELATIONSHIPS

* allow adding string values for scalar args

* comment code

* add update relationship feature

* cover edge cases for update remote rel

* fix semver issue where sometimes the query would never be called

* remove unnecessary fields from schema tree

* stable

* wip

* wip

* wip

* add version checks

* invalidate remote schema cache appropriately

* Remove unnecessary logs
wawhal added a commit to wawhal/graphql-engine that referenced this pull request Jul 23, 2019
* render 404 for nonexistent resources (hasura#2341)

* update console dev logging + add logging disable instructions to README (hasura#2388)

* update table rename handling (hasura#2393)

* suggest column default values (hasura#2352)

* fix postgres query to fetch pg_types default functions (close hasura#2399) (hasura#2402)

* add graphql-voyager to console (close hasura#314) (hasura#2369)

* clear header state for remote-schema (close hasura#2396) (hasura#2401)

* change browse rows action buttons heading id (close hasura#2403) (hasura#2413)

* created docker compose for build and launch of tutorial (hasura#2406)

* fix renaming of columns used in insert permission (fix hasura#2398) (hasura#2414)

* graphql2chartjs: fix mapping of non-array types (hasura#2307)

* add name of ci environment to telemetry data (hasura#2382)

* learn: update react native tutorial with videos (hasura#2390)

* create down migration when a column is dropped (close hasura#2291) (hasura#2385)

* add new column row during add table only after completed prev column def (hasura#2428)

* add a make rule to build server docker image locally (hasura#2410)

* learn: fix twitter share image on homepage (hasura#2437)

* add note on exporting multiple schemas as migration (hasura#2436)

* fix browse rows query error handling + boolean filter value (close hasura#2421) (hasura#2440)

* graphql2chartjs: bump version to 0.3.0 (hasura#2445)

* fix to show error notification when run sql fails in cli mode (close hasura#2438) (hasura#2446)

* freeze requirements.txt for server tests (hasura#2450)

* update postgres permission documentation (fix hasura#2404) (hasura#2405)

* refactor AddTable validation on console (close hasura#1712) (hasura#2408)

* change default type placeholder from 'text' to type (fix 2394) (hasura#2458)

* add server version to console html (close hasura#2444) (hasura#2452)

* fix type placeholders in console insert/edit row (hasura#2460)

* fix relationship page error if array fk relationship exists with table in another schema (hasura#2459)

* infer relationship type using uniqueness constraint of foreign key (close hasura#969) (hasura#2347)

* use server version from console html (hasura#2464)

* add schema explorer ui

* wire up create API, WIP

* ui fixes

* integrate with proxy API

* fetch remote relationships in loadSchema

* fixes

* finish up UI for remote rels; waiting on edit API

* break relationships ui into sections

* move graphql schema to local state

* update relationship label

* restructure

* update styles; add tooltips

* filter out fields (scalar type || wrapped scalar type) and do accept any args

* remove an unnecessary log

* version check init

* add version check for remote relationship on loadSchema

* use FT_REMOTE_RELATIONSHIPS

* allow adding string values for scalar args

* comment code

* add update relationship feature

* cover edge cases for update remote rel

* fix semver issue where sometimes the query would never be called

* remove unnecessary fields from schema tree

* stable

* wip

* wip

* wip

* add version checks

* invalidate remote schema cache appropriately

* Remove unnecessary logs
wawhal added a commit to wawhal/graphql-engine that referenced this pull request Jul 24, 2019
* render 404 for nonexistent resources (hasura#2341)

* update console dev logging + add logging disable instructions to README (hasura#2388)

* update table rename handling (hasura#2393)

* suggest column default values (hasura#2352)

* fix postgres query to fetch pg_types default functions (close hasura#2399) (hasura#2402)

* add graphql-voyager to console (close hasura#314) (hasura#2369)

* clear header state for remote-schema (close hasura#2396) (hasura#2401)

* change browse rows action buttons heading id (close hasura#2403) (hasura#2413)

* created docker compose for build and launch of tutorial (hasura#2406)

* fix renaming of columns used in insert permission (fix hasura#2398) (hasura#2414)

* graphql2chartjs: fix mapping of non-array types (hasura#2307)

* add name of ci environment to telemetry data (hasura#2382)

* learn: update react native tutorial with videos (hasura#2390)

* create down migration when a column is dropped (close hasura#2291) (hasura#2385)

* add new column row during add table only after completed prev column def (hasura#2428)

* add a make rule to build server docker image locally (hasura#2410)

* learn: fix twitter share image on homepage (hasura#2437)

* add note on exporting multiple schemas as migration (hasura#2436)

* fix browse rows query error handling + boolean filter value (close hasura#2421) (hasura#2440)

* graphql2chartjs: bump version to 0.3.0 (hasura#2445)

* fix to show error notification when run sql fails in cli mode (close hasura#2438) (hasura#2446)

* freeze requirements.txt for server tests (hasura#2450)

* update postgres permission documentation (fix hasura#2404) (hasura#2405)

* refactor AddTable validation on console (close hasura#1712) (hasura#2408)

* change default type placeholder from 'text' to type (fix 2394) (hasura#2458)

* add server version to console html (close hasura#2444) (hasura#2452)

* fix type placeholders in console insert/edit row (hasura#2460)

* fix relationship page error if array fk relationship exists with table in another schema (hasura#2459)

* infer relationship type using uniqueness constraint of foreign key (close hasura#969) (hasura#2347)

* use server version from console html (hasura#2464)

* add schema explorer ui

* wire up create API, WIP

* ui fixes

* integrate with proxy API

* fetch remote relationships in loadSchema

* fixes

* finish up UI for remote rels; waiting on edit API

* break relationships ui into sections

* move graphql schema to local state

* update relationship label

* restructure

* update styles; add tooltips

* filter out fields (scalar type || wrapped scalar type) and do accept any args

* remove an unnecessary log

* version check init

* add version check for remote relationship on loadSchema

* use FT_REMOTE_RELATIONSHIPS

* allow adding string values for scalar args

* comment code

* add update relationship feature

* cover edge cases for update remote rel

* fix semver issue where sometimes the query would never be called

* remove unnecessary fields from schema tree

* stable

* wip

* wip

* wip

* add version checks

* invalidate remote schema cache appropriately

* Remove unnecessary logs
wawhal added a commit to wawhal/graphql-engine that referenced this pull request Jul 24, 2019
* render 404 for nonexistent resources (hasura#2341)

* update console dev logging + add logging disable instructions to README (hasura#2388)

* update table rename handling (hasura#2393)

* suggest column default values (hasura#2352)

* fix postgres query to fetch pg_types default functions (close hasura#2399) (hasura#2402)

* add graphql-voyager to console (close hasura#314) (hasura#2369)

* clear header state for remote-schema (close hasura#2396) (hasura#2401)

* change browse rows action buttons heading id (close hasura#2403) (hasura#2413)

* created docker compose for build and launch of tutorial (hasura#2406)

* fix renaming of columns used in insert permission (fix hasura#2398) (hasura#2414)

* graphql2chartjs: fix mapping of non-array types (hasura#2307)

* add name of ci environment to telemetry data (hasura#2382)

* learn: update react native tutorial with videos (hasura#2390)

* create down migration when a column is dropped (close hasura#2291) (hasura#2385)

* add new column row during add table only after completed prev column def (hasura#2428)

* add a make rule to build server docker image locally (hasura#2410)

* learn: fix twitter share image on homepage (hasura#2437)

* add note on exporting multiple schemas as migration (hasura#2436)

* fix browse rows query error handling + boolean filter value (close hasura#2421) (hasura#2440)

* graphql2chartjs: bump version to 0.3.0 (hasura#2445)

* fix to show error notification when run sql fails in cli mode (close hasura#2438) (hasura#2446)

* freeze requirements.txt for server tests (hasura#2450)

* update postgres permission documentation (fix hasura#2404) (hasura#2405)

* refactor AddTable validation on console (close hasura#1712) (hasura#2408)

* change default type placeholder from 'text' to type (fix 2394) (hasura#2458)

* add server version to console html (close hasura#2444) (hasura#2452)

* fix type placeholders in console insert/edit row (hasura#2460)

* fix relationship page error if array fk relationship exists with table in another schema (hasura#2459)

* infer relationship type using uniqueness constraint of foreign key (close hasura#969) (hasura#2347)

* use server version from console html (hasura#2464)

* add schema explorer ui

* wire up create API, WIP

* ui fixes

* integrate with proxy API

* fetch remote relationships in loadSchema

* fixes

* finish up UI for remote rels; waiting on edit API

* break relationships ui into sections

* move graphql schema to local state

* update relationship label

* restructure

* update styles; add tooltips

* filter out fields (scalar type || wrapped scalar type) and do accept any args

* remove an unnecessary log

* version check init

* add version check for remote relationship on loadSchema

* use FT_REMOTE_RELATIONSHIPS

* allow adding string values for scalar args

* comment code

* add update relationship feature

* cover edge cases for update remote rel

* fix semver issue where sometimes the query would never be called

* remove unnecessary fields from schema tree

* stable

* wip

* wip

* wip

* add version checks

* invalidate remote schema cache appropriately

* Remove unnecessary logs
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
hasura-bot pushed a commit that referenced this pull request Sep 29, 2021
### Description

This PR implements operation timeouts, as specced in #1232.

RFC: [rfcs/operation-timeout-api-limits.md](https://github.com/hasura/graphql-engine-mono/blob/c025a90fe9779436bc0188a2bbf0ad95b5ed1f32/rfcs/operation-timeout-api-limits.md)

There's still some things to be done (tests and docs most notably), but apart from that it can
be reviewed. I'd still appreciate feedback on the RFC!

TODO:
- [x] break out the `ApiLimits` refactoring into a separate PR: #2103
- [x] finish the `pg-client-hs` PR: hasura/pg-client-hs#39
- [x] remove configurability, after testing, prior to merging
- [ ] tests: #2390 has some tests that I've run locally to confirm things work on a fundamental level
- [x] changelog
- [x] documentation
- [x] fill in the detailed PR checklist

### Changelog

- [x] `CHANGELOG.md` is updated with user-facing content relevant to this PR. If no changelog is required, then add the `no-changelog-required` label.

### Affected components

- [x] Server
- [ ] Console
- [ ] CLI
- [x] Docs
- [ ] Tests

### Related Issues

Product spec: #1232.

### Solution and Design

Compare `rfcs/operation-timeout-api-limits.md`.

### Steps to test and verify

Configure operation timeouts, e.g. by posting

```
{
  "type": "set_api_limits",
  "args": {
    "operation_timeout": {
      "global": 3
    }
  }
}
```

to `v1/metadata` to set an operation timeout of 3s. Then verify that
1. non-admin queries that take longer than 3s time out with a nice error message
2. that those queries return after ~3s (at least for postgres)
3. also that everything else still works as usual

### Limitations, known bugs & workarounds
- while this will cause slow queries against any backends to fail, it's only verified to actually interrupt queries against postgres
- this will only successfully short-cut (cancel) queries to postgres if the database server is responsive

#### Catalog upgrade
Does this PR change Hasura Catalog version?
- [x] No

#### Metadata

Does this PR add a new Metadata feature?
- [x] Yes
  - Does `run_sql` auto manages the new metadata through schema diffing?
    - [x] Not required
  - Does `run_sql` auto manages the definitions of metadata on renaming?
    - [x] Not required
  - Does `export_metadata`/`replace_metadata` supports the new metadata added?
    - [x] Yes

#### GraphQL
- [x] No new GraphQL schema is generated

#### Breaking changes

- [x] No Breaking changes

PR-URL: hasura/graphql-engine-mono#1593
GitOrigin-RevId: f0582d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/community Related to community content s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants