create down migration when a column is dropped (close #2291) #2385

arvi3411301 · 2019-06-17T12:59:42Z

Description

Dropping a column does not generate appropriate down migration. This PR fixes the console to generate down migration for the same.

Affected components

Console
CLI

Related Issues

#2291

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

…WSS Endpoints, close hasura#2330

…2330

netlify · 2019-06-17T13:00:48Z

Deploy preview for hasura-docs ready!

Built with commit 3013d8e

https://deploy-preview-2385--hasura-docs.netlify.com

console/src/components/Services/Data/TableModify/ModifyActions.js

hasura-bot · 2019-06-18T18:07:20Z

Review app for commit 074c4b6 deployed to Heroku: https://hge-ci-pull-2385.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2385-074c4b60

rikinsk-zz · 2019-06-19T08:21:38Z

@arvi3411301 I cant read the warning after deleting column. it comes and auto disappears in a second, The warning should persist on the screen

console/src/components/Services/Common/Notification.js

…to issue-2291

hasura-bot · 2019-06-19T10:08:43Z

Review app for commit 8adc5b9 deployed to Heroku: https://hge-ci-pull-2385.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2385-8adc5b90

hasura-bot · 2019-06-19T10:28:43Z

Review app for commit 1e6a38a deployed to Heroku: https://hge-ci-pull-2385.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2385-1e6a38a6

hasura-bot · 2019-06-20T08:02:17Z

Review app for commit 1a77d67 deployed to Heroku: https://hge-ci-pull-2385.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2385-1a77d678

hasura-bot · 2019-06-20T12:59:30Z

Review app for commit 1fae0e3 deployed to Heroku: https://hge-ci-pull-2385.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2385-1fae0e3d

hasura-bot · 2019-06-25T10:27:57Z

Review app for commit 4c96399 deployed to Heroku: https://hge-ci-pull-2385.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2385-4c963990

hasura-bot · 2019-06-25T11:34:29Z

Review app for commit cfd2c87 deployed to Heroku: https://hge-ci-pull-2385.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2385-cfd2c870

hasura-bot · 2019-06-25T12:12:53Z

Review app for commit 5372d5f deployed to Heroku: https://hge-ci-pull-2385.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2385-5372d5fb

hasura-bot · 2019-06-25T12:47:41Z

Review app for commit 2d81779 deployed to Heroku: https://hge-ci-pull-2385.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2385-2d81779e

…to issue-2291

hasura-bot · 2019-06-26T11:28:26Z

Review app for commit b1fff61 deployed to Heroku: https://hge-ci-pull-2385.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2385-b1fff619

hasura-bot · 2019-06-26T11:42:14Z

Review app for commit f9c1023 deployed to Heroku: https://hge-ci-pull-2385.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2385-f9c10233

… column

…to issue-2291

hasura-bot · 2019-06-26T13:08:28Z

Review app for commit 3013d8e deployed to Heroku: https://hge-ci-pull-2385.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2385-3013d8ee

shahidhk

LGTM

hasura-bot · 2019-06-26T13:12:47Z

Review app https://hge-ci-pull-2385.herokuapp.com is deleted

* render 404 for nonexistent resources (hasura#2341) * update console dev logging + add logging disable instructions to README (hasura#2388) * update table rename handling (hasura#2393) * suggest column default values (hasura#2352) * fix postgres query to fetch pg_types default functions (close hasura#2399) (hasura#2402) * add graphql-voyager to console (close hasura#314) (hasura#2369) * clear header state for remote-schema (close hasura#2396) (hasura#2401) * change browse rows action buttons heading id (close hasura#2403) (hasura#2413) * created docker compose for build and launch of tutorial (hasura#2406) * fix renaming of columns used in insert permission (fix hasura#2398) (hasura#2414) * graphql2chartjs: fix mapping of non-array types (hasura#2307) * add name of ci environment to telemetry data (hasura#2382) * learn: update react native tutorial with videos (hasura#2390) * create down migration when a column is dropped (close hasura#2291) (hasura#2385) * add new column row during add table only after completed prev column def (hasura#2428) * add a make rule to build server docker image locally (hasura#2410) * learn: fix twitter share image on homepage (hasura#2437) * add note on exporting multiple schemas as migration (hasura#2436) * fix browse rows query error handling + boolean filter value (close hasura#2421) (hasura#2440) * graphql2chartjs: bump version to 0.3.0 (hasura#2445) * fix to show error notification when run sql fails in cli mode (close hasura#2438) (hasura#2446) * freeze requirements.txt for server tests (hasura#2450) * update postgres permission documentation (fix hasura#2404) (hasura#2405) * refactor AddTable validation on console (close hasura#1712) (hasura#2408) * change default type placeholder from 'text' to type (fix 2394) (hasura#2458) * add server version to console html (close hasura#2444) (hasura#2452) * fix type placeholders in console insert/edit row (hasura#2460) * fix relationship page error if array fk relationship exists with table in another schema (hasura#2459) * infer relationship type using uniqueness constraint of foreign key (close hasura#969) (hasura#2347) * use server version from console html (hasura#2464) * add schema explorer ui * wire up create API, WIP * ui fixes * integrate with proxy API * fetch remote relationships in loadSchema * fixes * finish up UI for remote rels; waiting on edit API * break relationships ui into sections * move graphql schema to local state * update relationship label * restructure * update styles; add tooltips * filter out fields (scalar type || wrapped scalar type) and do accept any args * remove an unnecessary log * version check init * add version check for remote relationship on loadSchema * use FT_REMOTE_RELATIONSHIPS * allow adding string values for scalar args * comment code * add update relationship feature * cover edge cases for update remote rel * fix semver issue where sometimes the query would never be called * remove unnecessary fields from schema tree * stable * wip * wip * wip * add version checks * invalidate remote schema cache appropriately * Remove unnecessary logs

…asura#2385)

arvi3411301 added 3 commits June 13, 2019 15:22

fix CLI console subscriptions connect via WS instead of WSS on HTTPS/…

d6b77be

…WSS Endpoints, close hasura#2330

Merge branch 'master' of github.com:hasura/graphql-engine into issue-…

41ce10e

…2330

fix to create down migration on dropping a column, close hasura#2291

367f175

arvi3411301 requested review from rikinsk-zz and shahidhk as code owners June 17, 2019 12:59

arvi3411301 changed the title ~~Issue 2291~~ fix to create down migration on dropping a column, close #2291 Jun 17, 2019

strongSoda added c/cli Related to CLI c/console Related to console labels Jun 17, 2019

use column udt_name as column type

a6a7ae7

arvi3411301 commented Jun 17, 2019

View reviewed changes

console/src/components/Services/Data/TableModify/ModifyActions.js Outdated Show resolved Hide resolved

Merge branch 'master' into issue-2291

074c4b6

rikinsk-zz suggested changes Jun 19, 2019

View reviewed changes

console/src/components/Services/Common/Notification.js Outdated Show resolved Hide resolved

console/src/components/Services/Common/Notification.js Outdated Show resolved Hide resolved

arvi3411301 added 3 commits June 19, 2019 15:16

Merge branch 'master' into issue-2291

0c1487e

Merge branch 'issue-2291' of github.com:arvi3411301/graphql-engine in…

c8bdb26

…to issue-2291

fix review comments

8adc5b9

remove reqBody from showErrorNotification

1e6a38a

Merge branch 'master' into issue-2291

1a77d67

fix notifications

1fae0e3

rikinsk-zz self-requested a review June 20, 2019 13:42

update modify behavipur

4c96399

rikinsk added 2 commits June 25, 2019 16:55

fix notifications

28232bb

Merge branch 'master' into issue-2291

cfd2c87

update notifications

5372d5f

show comment in col summary

2d81779

rikinsk and others added 5 commits June 26, 2019 14:20

fix error handling

32479b1

add constraints to down migration

3104cb2

Merge branch 'issue-2291' of github.com:arvi3411301/graphql-engine in…

c9f36e8

…to issue-2291

add column default to down migration

b1fff61

Merge branch 'issue-2291' of github.com:arvi3411301/graphql-engine in…

a510ffc

…to issue-2291

fix test

f9c1023

arvi3411301 added 2 commits June 26, 2019 18:24

add opp_foreign_key_constraints to down migration and cascade to drop…

956b9d2

… column

Merge branch 'issue-2291' of github.com:arvi3411301/graphql-engine in…

99fa312

…to issue-2291

rikinsk-zz approved these changes Jun 26, 2019

View reviewed changes

Merge branch 'master' into issue-2291

3013d8e

shahidhk approved these changes Jun 26, 2019

View reviewed changes

shahidhk changed the title ~~fix to create down migration on dropping a column, close #2291~~ create down migration when a column is dropped (close #2291) Jun 26, 2019

shahidhk merged commit c17bf2f into hasura:master Jun 26, 2019

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020

create down migration when a column is dropped (close hasura#2291) (h…

678d835

…asura#2385)

create down migration when a column is dropped (close #2291) #2385

create down migration when a column is dropped (close #2291) #2385

Uh oh!

Conversation

arvi3411301 commented Jun 17, 2019

Description

Affected components

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Uh oh!

netlify bot commented Jun 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

hasura-bot commented Jun 18, 2019

Uh oh!

rikinsk-zz commented Jun 19, 2019

Uh oh!

Uh oh!

Uh oh!

hasura-bot commented Jun 19, 2019

Uh oh!

hasura-bot commented Jun 19, 2019

Uh oh!

hasura-bot commented Jun 20, 2019

Uh oh!

hasura-bot commented Jun 20, 2019

Uh oh!

hasura-bot commented Jun 25, 2019

Uh oh!

hasura-bot commented Jun 25, 2019

Uh oh!

hasura-bot commented Jun 25, 2019

Uh oh!

hasura-bot commented Jun 25, 2019

Uh oh!

hasura-bot commented Jun 26, 2019

Uh oh!

hasura-bot commented Jun 26, 2019

Uh oh!

hasura-bot commented Jun 26, 2019

Uh oh!

shahidhk left a comment

Choose a reason for hiding this comment

Uh oh!

hasura-bot commented Jun 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

netlify bot commented Jun 17, 2019 •

edited

Loading