add name of ci environment to telemetry data #2382

ajeetdsouza · 2019-06-17T06:50:57Z

Description

Add the name of the continuous integration environment (Travis, Circle, etc.) that the server is running on to telemetry.

Affected components

Server
Docs

Related Issues

None

Solution and Design

Use the ci-info package to detect current CI environment, add a new field for it in the telemetry JSON.

Steps to test and verify

To verify, one could log the generated JSON file from telemetry with and without CI-specific environment variables such as TRAVIS.

Limitations, known bugs & workarounds

None

To the Reviewer (server)

No new modules have been added
A new dependency has been added to the ci-info package
HasuraTelemetry now has a _htCi :: Maybe CI field
checkForUpdates now uses the CI.isCI function
mkPayload now adds information from CI.getCI to the telemetry payload

Critical modules

src-lib/Hasura/Server/CheckUpdates.hs
src-lib/Hasura/Server/Telemetry.hs

Add CI name to telemetry

hasura-bot · 2019-06-17T06:51:00Z

Beep boop! 🤖

Hey @ajeetdsouza, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

netlify · 2019-06-17T06:51:59Z

Deploy preview for hasura-docs ready!

Built with commit 1233d17

https://deploy-preview-2382--hasura-docs.netlify.com

hasura-bot · 2019-06-17T07:32:33Z

Review app for commit 9dabf24 deployed to Heroku: https://hge-ci-pull-2382.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2382-9dabf24c

hasura-bot · 2019-06-19T11:58:22Z

Review app for commit 3f9b497 deployed to Heroku: https://hge-ci-pull-2382.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2382-3f9b4978

rakeshkky · 2019-06-21T06:55:52Z

server/src-lib/Hasura/Server/CheckUpdates.hs

-      case isCI of
-        Just "true" -> return $ buildUrl "server-ci"
-        _           -> return $ buildUrl "server"
+      let buildUrl agent = "https://releases.hasura.io/graphql-engine?agent=" <> agent <> "&version=" <> currentVersion


More than 80 chars!

rakeshkky · 2019-06-21T06:59:32Z

server/src-lib/Hasura/Server/Telemetry.hs

    schemaCache <- fmap fst $ readIORef cacheRef
    let metrics = computeMetrics schemaCache
-        payload = A.encode $ mkPayload dbId instanceId currentVersion metrics
+    p <- mkPayload dbId instanceId currentVersion metrics


A.encode <$> mkPayload ....

hasura-bot · 2019-06-21T09:09:30Z

Review app for commit 62f84b2 deployed to Heroku: https://hge-ci-pull-2382.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2382-62f84b28

rakeshkky

LGTM server

hasura-bot · 2019-06-21T13:06:49Z

Review app for commit 50ea368 deployed to Heroku: https://hge-ci-pull-2382.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2382-50ea3683

hasura-bot · 2019-06-25T11:02:10Z

Review app for commit 806b7ef deployed to Heroku: https://hge-ci-pull-2382.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2382-806b7efa

shahidhk

verified the functionality

hasura-bot · 2019-06-26T05:38:47Z

Review app for commit 1233d17 deployed to Heroku: https://hge-ci-pull-2382.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2382-1233d177

hasura-bot · 2019-06-26T06:23:42Z

Review app https://hge-ci-pull-2382.herokuapp.com is deleted

hasura-bot · 2019-06-26T06:23:43Z

Beep boop! 🤖

Whoa! 🎉 🎉 💃

Awesome work @ajeetdsouza! 💪 🏆 All of us at Hasura ❤️ what you did.

Thanks again 🤗

* render 404 for nonexistent resources (hasura#2341) * update console dev logging + add logging disable instructions to README (hasura#2388) * update table rename handling (hasura#2393) * suggest column default values (hasura#2352) * fix postgres query to fetch pg_types default functions (close hasura#2399) (hasura#2402) * add graphql-voyager to console (close hasura#314) (hasura#2369) * clear header state for remote-schema (close hasura#2396) (hasura#2401) * change browse rows action buttons heading id (close hasura#2403) (hasura#2413) * created docker compose for build and launch of tutorial (hasura#2406) * fix renaming of columns used in insert permission (fix hasura#2398) (hasura#2414) * graphql2chartjs: fix mapping of non-array types (hasura#2307) * add name of ci environment to telemetry data (hasura#2382) * learn: update react native tutorial with videos (hasura#2390) * create down migration when a column is dropped (close hasura#2291) (hasura#2385) * add new column row during add table only after completed prev column def (hasura#2428) * add a make rule to build server docker image locally (hasura#2410) * learn: fix twitter share image on homepage (hasura#2437) * add note on exporting multiple schemas as migration (hasura#2436) * fix browse rows query error handling + boolean filter value (close hasura#2421) (hasura#2440) * graphql2chartjs: bump version to 0.3.0 (hasura#2445) * fix to show error notification when run sql fails in cli mode (close hasura#2438) (hasura#2446) * freeze requirements.txt for server tests (hasura#2450) * update postgres permission documentation (fix hasura#2404) (hasura#2405) * refactor AddTable validation on console (close hasura#1712) (hasura#2408) * change default type placeholder from 'text' to type (fix 2394) (hasura#2458) * add server version to console html (close hasura#2444) (hasura#2452) * fix type placeholders in console insert/edit row (hasura#2460) * fix relationship page error if array fk relationship exists with table in another schema (hasura#2459) * infer relationship type using uniqueness constraint of foreign key (close hasura#969) (hasura#2347) * use server version from console html (hasura#2464) * add schema explorer ui * wire up create API, WIP * ui fixes * integrate with proxy API * fetch remote relationships in loadSchema * fixes * finish up UI for remote rels; waiting on edit API * break relationships ui into sections * move graphql schema to local state * update relationship label * restructure * update styles; add tooltips * filter out fields (scalar type || wrapped scalar type) and do accept any args * remove an unnecessary log * version check init * add version check for remote relationship on loadSchema * use FT_REMOTE_RELATIONSHIPS * allow adding string values for scalar args * comment code * add update relationship feature * cover edge cases for update remote rel * fix semver issue where sometimes the query would never be called * remove unnecessary fields from schema tree * stable * wip * wip * wip * add version checks * invalidate remote schema cache appropriately * Remove unnecessary logs

shahidhk and others added 6 commits June 2, 2019 20:25

add ci env to telemetry data

7a4a1bc

add drone

702f021

Add CI name to telemetry

2f44271

Add CI to telemetry docs

815c357

Update ci-info-hs dependency

280cf9b

Add CI name to telemetry (#4)

9dabf24

Add CI name to telemetry

ajeetdsouza requested review from 0x777 and rikinsk-zz as code owners June 17, 2019 06:50

shahidhk added the c/server Related to server label Jun 17, 2019

ajeetdsouza self-assigned this Jun 17, 2019

update telemetry docs (#5)

3f9b497

shahidhk changed the title ~~Add name of CI environment to telemetry~~ add name of ci environment to telemetry data Jun 19, 2019

shahidhk self-requested a review June 19, 2019 11:51

ajeetdsouza added s/do-not-merge Do not merge this pull request to master and removed s/do-not-merge Do not merge this pull request to master labels Jun 19, 2019

ajeetdsouza requested a review from rakeshkky June 19, 2019 12:19

rakeshkky reviewed Jun 21, 2019

View reviewed changes

Improve formatting (#6)

62f84b2

Merge branch 'master' into telemetry-cicd

50ea368

rakeshkky previously approved these changes Jun 21, 2019

View reviewed changes

Pass CI parameter when checking for update (#7)

806b7ef

shahidhk dismissed rakeshkky’s stale review via 806b7ef June 25, 2019 10:48

shahidhk approved these changes Jun 26, 2019

View reviewed changes

Merge branch 'master' into telemetry-cicd

1233d17

shahidhk merged commit 08df38a into hasura:master Jun 26, 2019

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020

add name of ci environment to telemetry data (hasura#2382)

d698e38

add name of ci environment to telemetry data #2382

add name of ci environment to telemetry data #2382

Uh oh!

Conversation

ajeetdsouza commented Jun 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Affected components

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

To the Reviewer (server)

Uh oh!

hasura-bot commented Jun 17, 2019

Uh oh!

netlify bot commented Jun 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hasura-bot commented Jun 17, 2019

Uh oh!

hasura-bot commented Jun 19, 2019

Uh oh!

rakeshkky Jun 21, 2019

Choose a reason for hiding this comment

Uh oh!

rakeshkky Jun 21, 2019

Choose a reason for hiding this comment

Uh oh!

hasura-bot commented Jun 21, 2019

Uh oh!

rakeshkky left a comment

Choose a reason for hiding this comment

Uh oh!

hasura-bot commented Jun 21, 2019

Uh oh!

hasura-bot commented Jun 25, 2019

Uh oh!

shahidhk left a comment

Choose a reason for hiding this comment

Uh oh!

hasura-bot commented Jun 26, 2019

Uh oh!

hasura-bot commented Jun 26, 2019

Uh oh!

hasura-bot commented Jun 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ajeetdsouza commented Jun 17, 2019 •

edited

Loading

netlify bot commented Jun 17, 2019 •

edited

Loading