fix CLI console subscriptions connect via WS instead of WSS on HTTPS/WSS Endpoints, close #2330 #2374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WSS Endpoints, close hasura#2330
|
Deploy preview for hasura-docs ready! Built with commit d6b77be |
rikinsk-zz
approved these changes
Jun 13, 2019
Contributor
|
Review app https://hge-ci-pull-2374.herokuapp.com is deleted |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If GraphQL endpoint is http, protocols used should be http / ws
If GraphQL endpoint is https, protocols used should be https / wss
Affected components
Related Issues
#2330
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds