add limit in select permission and override query limit (close #178) #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app available at: https://hge-ci-pull-237.herokuapp.com |
|
Review app available at: https://hge-ci-pull-237.herokuapp.com |
|
Review app available at: https://hge-ci-pull-237.herokuapp.com |
|
Review app available at: https://hge-ci-pull-237.herokuapp.com |
|
Review app available at: https://hge-ci-pull-237.herokuapp.com |
karthikvt26
previously approved these changes
Aug 6, 2018
0x777
reviewed
Aug 6, 2018
| onlyPositiveInt :: MonadError QErr m => Maybe Int -> m () | ||
| onlyPositiveInt Nothing = return () | ||
| onlyPositiveInt (Just i) = when (i < 0) $ throw400 NotSupported | ||
| "negative values are not supported" |
There was a problem hiding this comment.
"unexpected negative value"
This function should take Int not Maybe Int. Use mapM/forM to apply it on a container of type t a.
|
Also we seem to be losing the path information. Can you check where and why? |
|
Review app available at: https://hge-ci-pull-237.herokuapp.com |
0x777
approved these changes
Aug 6, 2018
|
Review app https://hge-ci-pull-237.herokuapp.com is deleted |
hgiasac
pushed a commit
to hgiasac/graphql-engine
that referenced
this pull request
Dec 19, 2023
GitOrigin-RevId: d1e74f6f2b56d35f948262e5c4249575bb586cc4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.